(fix/oci-client): allow adding a token for OCI client #1600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rylev
reviewed
Jun 21, 2023
itowlson
previously requested changes
Jun 22, 2023
radu-matei
force-pushed
the
fix/pub-oci-client
branch
from
7d722c5 to
c0a3218
Compare
radu-matei
changed the title
|
@radu-matei the outstanding issue for me on this is https://github.com/fermyon/spin/pull/1600/files#r1237937342 (I mentioned it in chat a little while ago but should have noted it here as well) |
|
Eager to get this in for more convenient OCI testing. @radu-matei when you have a chance could you rebase and take a look at #1600 (comment)? |
vdice
force-pushed
the
fix/pub-oci-client
branch
from
c0a3218 to
3f6d570
Compare
|
(rebased with main) |
vdice
force-pushed
the
fix/pub-oci-client
branch
2 times, most recently
from
76ef26b to
4830443
Compare
This commit adds a public function on the OCI client to insert a token in the token cache (used by the Cloud plugin to insert Cloud's token) and stores the OCI manifest digst in `AppInfo` so it can be queried by `./well-known/spin/info` at deployment time. Signed-off-by: Radu Matei <radu.matei@fermyon.com>
vdice
force-pushed
the
fix/pub-oci-client
branch
from
4830443 to
a679d3a
Compare
lann
reviewed
Sep 11, 2023
Signed-off-by: Vaughn Dice <vaughn.dice@fermyon.com>
vdice
force-pushed
the
fix/pub-oci-client
branch
from
0b0d02f to
93df4ef
Compare
lann
dismissed
itowlson’s stale review
Looks like the concerns here have been refactored out of existence
lann
approved these changes
Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the underlying OCI client from the OCI crate used by Spin to be public. This is so that consumers of the client can configure the client (in particular, the token cache).