Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SIP for configuring and emitting observability #2303

Merged
merged 4 commits into from
Apr 29, 2024

Conversation

calebschoepp
Copy link
Collaborator

@calebschoepp calebschoepp commented Feb 28, 2024

Signed-off-by: Caleb Schoepp <caleb.schoepp@fermyon.com>
@calebschoepp calebschoepp marked this pull request as draft February 28, 2024 18:53
@calebschoepp calebschoepp requested a review from lann February 28, 2024 18:53
Comment on lines 47 to 48
[component.my-component]
allow_trace_context_propagation = true
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is probably worth giving its own section, e.g. [component.my-component.tracing]. In addition to toggling propagation we may want to have options to e.g. disable tracing entirely for particularly high-frequency components, customize span names, add metadata, etc.

Note that TOML would also let you write this as e.g.

[component.my-component]
tracing = { context_propagation = true }

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call. I'll make the change and add some of the obvious config to it.

Signed-off-by: Caleb Schoepp <caleb.schoepp@fermyon.com>
Signed-off-by: Caleb Schoepp <caleb.schoepp@fermyon.com>
Signed-off-by: Caleb Schoepp <caleb.schoepp@fermyon.com>
@calebschoepp
Copy link
Collaborator Author

I've stripped down this SIP to cover what has already been done. I'll give a few days for review and if I don't get any engagement I'll just merge it b/c the intention is basically just to track the work that has already been done.

@calebschoepp calebschoepp marked this pull request as ready for review April 29, 2024 20:55
@calebschoepp calebschoepp enabled auto-merge April 29, 2024 21:56
@vdice vdice disabled auto-merge April 29, 2024 22:24
@vdice vdice merged commit 214fb21 into fermyon:main Apr 29, 2024
1 check passed
@calebschoepp calebschoepp deleted the observability-sip branch May 29, 2024 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants