-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SIP for configuring and emitting observability #2303
Conversation
Signed-off-by: Caleb Schoepp <caleb.schoepp@fermyon.com>
docs/content/sips/017-configuring-and-emitting-observability.md
Outdated
Show resolved
Hide resolved
[component.my-component] | ||
allow_trace_context_propagation = true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is probably worth giving its own section, e.g. [component.my-component.tracing]
. In addition to toggling propagation we may want to have options to e.g. disable tracing entirely for particularly high-frequency components, customize span names, add metadata, etc.
Note that TOML would also let you write this as e.g.
[component.my-component]
tracing = { context_propagation = true }
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call. I'll make the change and add some of the obvious config to it.
docs/content/sips/017-configuring-and-emitting-observability.md
Outdated
Show resolved
Hide resolved
docs/content/sips/017-configuring-and-emitting-observability.md
Outdated
Show resolved
Hide resolved
docs/content/sips/017-configuring-and-emitting-observability.md
Outdated
Show resolved
Hide resolved
docs/content/sips/017-configuring-and-emitting-observability.md
Outdated
Show resolved
Hide resolved
Signed-off-by: Caleb Schoepp <caleb.schoepp@fermyon.com>
docs/content/sips/017-configuring-and-emitting-observability.md
Outdated
Show resolved
Hide resolved
Signed-off-by: Caleb Schoepp <caleb.schoepp@fermyon.com>
Signed-off-by: Caleb Schoepp <caleb.schoepp@fermyon.com>
I've stripped down this SIP to cover what has already been done. I'll give a few days for review and if I don't get any engagement I'll just merge it b/c the intention is basically just to track the work that has already been done. |
Rendered view