chore(crates): address lint errs when rust is at 1.77+ #2474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vdice
commented
Apr 25, 2024
Signed-off-by: Vaughn Dice <vaughn.dice@fermyon.com>
vdice
force-pushed
the
chore/fix-lints-rust-1.77
branch
from
2083a39
to
6696a0d
Compare
fibonacci1729
approved these changes
Apr 25, 2024
rylev
reviewed
Apr 26, 2024
| @@ -86,7 +86,7 @@ impl BadgerRecordManager { | |||
| let new = BadgerRecord { | |||
| name: name.to_owned(), | |||
| badgered_from: from.clone(), | |||
| badgered_to: to.iter().map(|v| <semver::Version>::clone(v)).collect(), | |||
| badgered_to: to.iter().cloned().map(<semver::Version>::clone).collect(), | |||
There was a problem hiding this comment.
Is the call to map still necessary?
There was a problem hiding this comment.
Oh, it could prove not to be! I admit I just did the barebones lint-suggested thing to get it to not error.
There was a problem hiding this comment.
I had the same thought yesterday but when i looked into it i started to believe that this is a false positive map_clone lint (=> rust-lang/rust-clippy#12271). I.e. removing the map yields an type error on the resulting collection.
A few things we could do but i'm not sure which is best:
- Drop the
clonedand attach#[allow(clippy::map_clone)]to this line - Keep as is and attach a note to remove the
clonedwhenever the false positive fix lands in rust proper (if it hasn't alread) just requires a rust version bump 🤷♂️ .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few lint errors block successfully running the lint and test targets locally when on a more recent version of rust than is pinned in Spin/CI. Hoping these updates are compatible with both scenarios...