Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax wasi 0.2 constraint #2935

Merged
merged 1 commit into from
Nov 26, 2024
Merged

Conversation

ogghead
Copy link
Contributor

@ogghead ogghead commented Nov 26, 2024

@ogghead ogghead force-pushed the relax-wasi-0.2-constraint branch from 29f824d to 0bb41b7 Compare November 26, 2024 03:14
Copy link
Contributor

@itowlson itowlson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hah, I just this moment thought, "eh looks like Darwin doesn't have bandwidth, I'll pick it up." My apologies for doubting you!

One "matter of taste" suggestion but otherwise looks good. Thanks!

crates/http/src/trigger.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@itowlson itowlson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ugh that was meant to be an approve

Signed-off-by: Darwin Boersma <darwin@sadlark.com>
@ogghead ogghead force-pushed the relax-wasi-0.2-constraint branch from 0bb41b7 to aa2a8cf Compare November 26, 2024 03:26
@itowlson itowlson enabled auto-merge November 26, 2024 03:53
@itowlson itowlson merged commit 3b6adc8 into fermyon:main Nov 26, 2024
17 checks passed
@ogghead ogghead deleted the relax-wasi-0.2-constraint branch November 26, 2024 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants