Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/chore(*): metadata label key updates, inject_env fix #75

Merged
merged 3 commits into from
Jun 25, 2024

Conversation

vdice
Copy link
Member

@vdice vdice commented Jun 25, 2024

  • Update inject_envs_with_prefix to exit gracefully if no env vars are found (grep by default exits non-zero if it doesn't find a match)
    • I hit this when running with OUTPUT=none... previously the function would exit non-zero trying to find K6_ prefixed env vars when there were none
  • Update the metadata label keys used by export_node_info (remove deprecations per https://kubernetes.io/docs/reference/labels-annotations-taints/)
  • Update kind-config to add the instance-type label, or else it returns a weird null string (--tag node_instance_type=^[[0;90mnull^[[0m) which in turn prevents the test run from ever proceeding past the initializing stage

vdice added 3 commits June 25, 2024 14:24
Signed-off-by: Vaughn Dice <vaughn.dice@fermyon.com>
Signed-off-by: Vaughn Dice <vaughn.dice@fermyon.com>
Signed-off-by: Vaughn Dice <vaughn.dice@fermyon.com>
Copy link
Collaborator

@kate-goldenring kate-goldenring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@vdice vdice merged commit e79d7ef into fermyon:main Jun 25, 2024
2 checks passed
@vdice vdice deleted the fix/metadata-and-grep branch June 25, 2024 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants