-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cli): Turn Mintlify migrator into a CLI command #5106
base: main
Are you sure you want to change the base?
Conversation
), | ||
JSON.stringify( | ||
{ | ||
version: "*", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: ideally this would be the latest version of fern available, wonder if we can pass that in from the cliContext
in cli.ts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch! I believe I did this properly - let me know if not
}: { directory?: AbsoluteFilePath; openApiArg?: string } = {}): Promise<AbsoluteFilePath> { | ||
openApiArg, | ||
mintJsonArg | ||
}: { directory?: AbsoluteFilePath; openApiArg?: string; mintJsonArg?: string } = {}): Promise<AbsoluteFilePath> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: would probably make this accept a discriminated union of args and it can either be openapi or mintlify (cause i dont think --openapi
and --mintlify
together would work)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dsinghvi Took a slightly different path vs. a discriminated union but achieved a similar outcome. Let me know what you think!
Up to add a changelog entry to |
packages/cli/cli/versions.yml
Outdated
The Fern CLI now supports initializing with a Mintlify project. | ||
type: fix | ||
irVersion: 53 | ||
version: 0.45.0-rc33 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would just pull from main to confirm there is no merge conflict
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should fix init.test.ts.snap
and make sure its easy to see the generated fern directory in a string format, otherwise good to merge! 🚀
a2ea71f
to
c8b45d5
Compare
Related to this card
This PR includes the functionality to run Mintlify migrations through the CLI. Some highlights in the PR:
@coderabbitai summary