Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prod Dockerfile #41

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

javierprovecho
Copy link

Add a prod Dockerfile for pilad with only 3 layers and weighting 11.2 MB. Also add DockerHub badge for /r/fern4lvarez/piladb in case of switching from dev image to prod image.

@fern4lvarez
Copy link
Owner

fern4lvarez commented Dec 20, 2016

Hi @javierprovecho!

First of all, thanks for submitting the first external PR of the history of piladb! This is great! 🎉

I love the idea of having a super lightweight image for running pilad on Docker. So I'm in for that. But in the other hand I'm a bit skeptical about adding a Dockerfile to the project root, as I'm obsess with keeping it clean, having on it only files related to the project itself, and not with the code, deployment or operational issues.

I'm thinking on these options in order to find a good compromise:

  • Integrating it into the dev directory, and documenting differences between the dev and the prod Dockerfiles and their usage.
  • Create a new directory dedicated production releases, e.g. prod, deploy, etc., where we can store this new Dockerfile and document how to use it. We can also document in this directory another deployment good practices, etc.

These are just ideas, you don't need to do it all now, just discuss an approach where we both agree and work on that.

For what it's worth, I will not merge this for now until we find the right way. 😌

@javierprovecho
Copy link
Author

@fern4lvarez sure!, I suggest creating a /prod or /deploy directory with its own README and maybe some examples in K8S and/or Compose. Do you agree?

@fern4lvarez
Copy link
Owner

@javierprovecho Let's go for deploy directory. All things containers (Dockerfile, k8s's chart, etc.) can live here.

Do you want to work on it? If so, please fix the conflicts, moving the new DockerHub badge to the dev's README file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants