Fix bucket deletion when using keyPrefix #102
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
When using the
keyPrefix
option along with having bucket deletion enabled, the following error occurs if the key prefix does not already exist:Closes #85
Proposed changes
The issue was with the
emptyBucket
function. With no items containing the keyPrefix, the keyPrefix logic resulted in an empty array of S3 objects being passed to thedeleteObjects
S3 request. This fix resolves the promise if there are no objects to delete.