Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag support #96

Merged
merged 3 commits into from
Jun 21, 2020
Merged

Tag support #96

merged 3 commits into from
Jun 21, 2020

Conversation

itsjesseyo
Copy link
Contributor

Background

Issue #95 -add support for tagging of buckets.

Proposed changes

Passing a tags object into a custom function and calling the aws cli putBucketTags command to set them

Proposed reviewers (optional)

[@ mentions of other contributors]

@fernando-mc
Copy link
Owner

This looks slick. Let me test it out and merge it in.

@fernando-mc
Copy link
Owner

This is a great PR and I'm sorry it's taken so long to merge @itsjesseyo! Merging and testing today.

@fernando-mc fernando-mc merged commit 858cea3 into fernando-mc:master Jun 21, 2020
@fernando-mc
Copy link
Owner

Just cut a new release. This should be included in v2.6.0 @itsjesseyo. Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants