warning: unneeded `return` statement
  --> src/events.rs:55:9
   |
55 | /         return Ok(thread::spawn(move || {
56 | |             let mut hold = true;
57 | |
58 | |             while hold {
...  |
64 | |             Ok(())
65 | |         }));
   | |___________^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
help: remove `return`
   |
55 ~         Ok(thread::spawn(move || {
56 +             let mut hold = true;
57 + 
58 +             while hold {
59 +                 self.wait_for_event(name.clone())?;
60 + 
61 +                 hold = handler(&mut self)?;
62 +             }
63 + 
64 +             Ok(())
65 ~         }))
   |

warning: unneeded `return` statement
  --> src/events.rs:40:9
   |
40 |         return conn.listen_event(name, handler);
   |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
   = note: `#[warn(clippy::needless_return)]` on by default
help: remove `return`
   |
40 -         return conn.listen_event(name, handler);
40 +         conn.listen_event(name, handler)
   |

warning: unused variable: `c`
   --> src/connection/simple.rs:188:47
    |
188 |             TypeConnectionContainer::PureRust(c) => {
    |                                               ^ help: if this is intentional, prefix it with an underscore: `_c`
    |
    = note: `#[warn(unused_variables)]` on by default

warning: casting to the same type is unnecessary (`u32` -> `u32`)
   --> rsfbclient-rust/src/xsqlda.rs:132:15
    |
132 |         match sqltype as u32 {
    |               ^^^^^^^^^^^^^^ help: try: `sqltype`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast

warning: casting integer literal to `u8` is unnecessary
   --> rsfbclient-rust/src/wire.rs:233:22
    |
233 |         dpb.extend(&[1 as u8]);
    |                      ^^^^^^^ help: try: `1_u8`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast

warning: casting integer literal to `u8` is unnecessary
   --> rsfbclient-rust/src/wire.rs:232:59
    |
232 |         dpb.extend(&[ibase::isc_dpb_no_db_triggers as u8, 1 as u8]);
    |                                                           ^^^^^^^ help: try: `1_u8`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast

warning: casting integer literal to `u8` is unnecessary
   --> rsfbclient-rust/src/wire.rs:228:52
    |
228 |     dpb.extend(&[ibase::isc_dpb_sql_dialect as u8, 1 as u8]);
    |                                                    ^^^^^^^ help: try: `1_u8`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast

warning: this function has too many arguments (8/7)
   --> rsfbclient-rust/src/wire.rs:196:1
    |
196 | / fn build_dpb(
197 | |     user: &str,
198 | |     pass: &str,
199 | |     protocol: ProtocolVersion,
...   |
204 | |     no_db_triggers: bool,
205 | | ) -> Bytes {
    | |__________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments

warning: this function has too many arguments (8/7)
   --> rsfbclient-rust/src/wire.rs:169:1
    |
169 | / pub fn create(
170 | |     db_name: &str,
171 | |     user: &str,
172 | |     pass: &str,
...   |
177 | |     dialect: Dialect,
178 | | ) -> Bytes {
    | |__________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments

warning: this function has too many arguments (8/7)
   --> rsfbclient-rust/src/wire.rs:135:1
    |
135 | / pub fn attach(
136 | |     db_name: &str,
137 | |     user: &str,
138 | |     pass: &str,
...   |
143 | |     no_db_triggers: bool,
144 | | ) -> Bytes {
    | |__________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
    = note: `#[warn(clippy::too_many_arguments)]` on by default

warning: casting to the same type is unnecessary (`usize` -> `usize`)
  --> rsfbclient-rust/src/util.rs:16:19
   |
16 |         let len = bytes.len() as usize;
   |                   ^^^^^^^^^^^^^^^^^^^^ help: try: `bytes.len()`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast

warning: the borrowed expression implements the required traits
   --> rsfbclient-rust/src/srp.rs:149:31
    |
149 |                 .chain_update(&key)
    |                               ^^^^ help: change this to: `key`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args

warning: the borrowed expression implements the required traits
   --> rsfbclient-rust/src/srp.rs:148:31
    |
148 |                 .chain_update(&b_pub.to_bytes_be())
    |                               ^^^^^^^^^^^^^^^^^^^^ help: change this to: `b_pub.to_bytes_be()`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args

warning: the borrowed expression implements the required traits
   --> rsfbclient-rust/src/srp.rs:147:31
    |
147 |                 .chain_update(&self.a_pub.to_bytes_be())
    |                               ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.a_pub.to_bytes_be()`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args

warning: the borrowed expression implements the required traits
   --> rsfbclient-rust/src/srp.rs:109:35
    |
109 |                     .chain_update(&self.a_pub.to_bytes_be())
    |                                   ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.a_pub.to_bytes_be()`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args

warning: the borrowed expression implements the required traits
  --> rsfbclient-rust/src/srp.rs:94:22
   |
94 |         Sha1::digest(&s.to_bytes_be())
   |                      ^^^^^^^^^^^^^^^^ help: change this to: `s.to_bytes_be()`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
   = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default

warning: casting integer literal to `u8` is unnecessary
   --> rsfbclient-rust/src/client.rs:478:22
    |
478 |             tpb.push(4 as u8);
    |                      ^^^^^^^ help: try: `4_u8`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast

warning: using `clone` on type `Option<&str>` which implements the `Copy` trait
   --> rsfbclient-rust/src/client.rs:433:13
    |
433 |             role_name.clone(),
    |             ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `role_name`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy

warning: using `clone` on type `Option<&str>` which implements the `Copy` trait
   --> rsfbclient-rust/src/client.rs:407:13
    |
407 |             role_name.clone(),
    |             ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `role_name`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
    = note: `#[warn(clippy::clone_on_copy)]` on by default

warning: manual implementation of `Option::map`
   --> rsfbclient-rust/src/client.rs:148:20
    |
148 |           let role = match &config.role_name {
    |  ____________________^
149 | |             Some(ro) => Some(ro.as_str()),
150 | |             None => None,
151 | |         };
    | |_________^ help: try: `config.role_name.as_ref().map(|ro| ro.as_str())`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map

warning: manual implementation of `Option::map`
  --> rsfbclient-rust/src/client.rs:96:20
   |
96 |           let role = match &config.role_name {
   |  ____________________^
97 | |             Some(ro) => Some(ro.as_str()),
98 | |             None => None,
99 | |         };
   | |_________^ help: try: `config.role_name.as_ref().map(|ro| ro.as_str())`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map
   = note: `#[warn(clippy::manual_map)]` on by default

warning: casting to the same type is unnecessary (`usize` -> `usize`)
  --> rsfbclient-rust/src/blr.rs:73:57
   |
73 |                         values.put_slice(&[0; 4][..4 - (bytes.len() as usize % 4)])
   |                                                         ^^^^^^^^^^^^^^^^^^^^ help: try: `bytes.len()`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
   = note: `#[warn(clippy::unnecessary_cast)]` on by default

warning: casting to the same type is unnecessary (`usize` -> `usize`)
  --> rsfbclient-native/src/xsqlda.rs:39:79
   |
39 |             let xsqlvar = unsafe { self.ptr.as_mut().sqlvar.get_unchecked_mut(col as usize) };
   |                                                                               ^^^^^^^^^^^^ help: try: `col`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast

warning: casting integer literal to `u8` is unnecessary
   --> rsfbclient-native/src/connection.rs:724:60
    |
724 |             dpb.extend(&[ibase::isc_dpb_sql_dialect as u8, 1 as u8]);
    |                                                            ^^^^^^^ help: try: `1_u8`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast

warning: casting to the same type is unnecessary (`usize` -> `usize`)
   --> rsfbclient-native/src/connection.rs:517:12
    |
517 |         Ok(affected as usize)
    |            ^^^^^^^^^^^^^^^^^ help: try: `affected`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast