Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional inline project edit button #271

Merged
merged 1 commit into from
Mar 14, 2023

Conversation

farlee2121
Copy link
Contributor

Motivation

A continuation of #269 which opened the project file on click in the explorer like Visual Studio does. The other popular F# editor is Ionide, which instead offers an inline button to edit the project file.

Supporting similar behavior could ease transition. It's also just a nice balanced option for quick access and a larger expand/collapse target.

Behavior after PR

By default there will be an inline button to edit the project file. This can be turned off in the settings.

image
image

Decisions worth noting

Config naming

The configuration option is "Open Project Inline Button Shown". This is less direct than "Show Inline Edit Project Button".
But, I chose it because it puts the two open project options right next to each other.

Alternatively, we could make the behaviors one configuration option with an enum.
I chose not to do that since it's plausible someone might want to toggle both.
Plus, I think only boolean config settings can be accessed directly from when constraints

Icon

I chose the edit icon for opening the project since it seemed intuitive. But VS Code has other sensible built-in icons like

  • file-code
  • go-to-file
  • arrow-right

@fernandoescolar fernandoescolar merged commit 3a99eb7 into fernandoescolar:main Mar 14, 2023
@fernandoescolar
Copy link
Owner

Amazing, thanks!

@fernandoescolar fernandoescolar added this to the v0.8.2 milestone Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants