Detect ARM64 macOS running on Apple Silicon #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also distinguishes whether 64-bit Node is running because we're actually on an Intel Mac or if it's just Rosetta 2 pretending to be one.
|
I also read that one can use the WebGL Renderer value which is Apple M1 but only works for chromium |
|
So is this pullrequest dead in the water and maintainer abandoned the project? |
|
Hey @feross could you take a look at this? This starts to hit more and more people as M1 chips get popular and there is unfortunately more and more node code that also downloads libraries / components that depend on the correct architecture info. |
|
BTW the best modern API for detecting architecture and bitness is WICG/proposals#40 (comment) |
|
@feross friendly ping! |
|
@feross another friendly ping :) |
feross
approved these changes
Feb 12, 2024
|
3.0.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also distinguishes whether x64 Node is running because we're actually on an Intel Mac or if it's just Rosetta 2 pretending to be one. If there's someone smarter than me who has a cleaner method please chime in ;)
Regarding #19: I didn't touch the Linux logic because I don't have as strong of an understanding there (and it seems a lot tricker to do — is it safe to assume
unameis on every machine?) but it'd be helpful to do the same thing there for both 32-bit and 64-bit ARM. If this PR looks good I can look further into it!