feat: use simpler env vars for win32 #27
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Agreed, this is a lot simpler and probably faster. @feross do you see something wrong with this approach? |
CanadaHonk
force-pushed
the
win32-env-vars
branch
from
a99f2c8 to
03c91e4
Compare
|
Fixed formatting to be like the rest of the repo. |
CanadaHonk
force-pushed
the
win32-env-vars
branch
from
03c91e4 to
abc4b4a
Compare
|
Updated to return |
Just use environment variables `PROCESSOR_ARCHITEW6432`/`PROCESSOR_ARCHITECTURE` on win32 instead of checking paths. Closes feross#26.
CanadaHonk
force-pushed
the
win32-env-vars
branch
from
abc4b4a to
b858dd6
Compare
|
Removed now unused imports in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just use environment variables
PROCESSOR_ARCHITEW6432/PROCESSOR_ARCHITECTUREon win32 instead of checking paths. Closes #26.Bonus when running as x86: probably much faster and works with no IO access. Also ~10% smaller filesize.