Undo instanceof Buffer changes
#155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It turns out that it's not possible to use `instanceof Buffer` safely,
like I thought.
It's not possible to use `instanceof Buffer` reliably in a browserify
context because there could be multiple different copies of the
'buffer' package in use.
This previous method (checking `buf._isBuffer`) works even for Buffer
instances that were created from another copy of the `buffer` package.
NOTE: It's possible to have two different "instances" of the 'buffer'
package, even if the 'buffer' package appears only once in the bundled
code. This can happen if you require 'buffer' in different ways, for
example:
`require('buffer')` vs. `require('buffer/')` vs. using the implicit
`Buffer` global.
You can confirm this by browserifying this code:
```js
console.log(require('buffer').Buffer === require('buffer/').Buffer) //
will be false
```
So, for this reason, `instanceof` won't work.
|
Released as 5.0.5. |
dcousens
reviewed
Feb 9, 2017
| // reliably in a browserify context because there could be multiple different | ||
| // copies of the 'buffer' package in use. This method works even for Buffer | ||
| // instances that were created from another copy of the `buffer` package. | ||
| // See: https://github.com/feross/buffer/issues/154 |
|
LGTM, nice work @feross. |
|
Live and learn! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that it's not possible to use
instanceof Buffersafely, like I thought.It's not possible to use
instanceof Bufferreliably in a browserify context because there could be multiple different copies of the 'buffer' package in use.This previous method (checking
buf._isBuffer) works even for Buffer instances that were created from another copy of thebufferpackage.NOTE: It's possible to have two different "instances" of the 'buffer' package, even if the 'buffer' package appears only once in the bundled code. This can happen if you require 'buffer' in different ways, for example:
require('buffer')vs.require('buffer/')vs. using the implicitBufferglobal.You can confirm this by browserifying this code:
So, for this reason,
instanceofwon't work.Fixes: #154