fix: remove console.error on init in regular browser #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes unnecessary console.error to match behavior of chrome-net
|
3.0.4 |
lidel
added a commit
to ipfs/ipfs-companion
that referenced
this pull request
Oct 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes unnecessary
console.errorduring the init.Motivation
We introduced support for feature detection of Google Chrome in #16.
Unfortunately, if sockets API is missing (eg. browser extension loads in regular browser – ipfs/ipfs-companion#716), console starts with irrelevant error:
Removing the error aligns
chrome-dgramwith existing behavior ofchrome-net, which does not print error to the console: