Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make getNavigationController function public #103

Merged
merged 1 commit into from
May 17, 2019
Merged

Make getNavigationController function public #103

merged 1 commit into from
May 17, 2019

Conversation

ferranabello
Copy link
Owner

  • Make getNavigationController function public
  • Use router's viewController accessor instead of force casting
  • Extend RouterProtocol instead of Router class if it makes sense
  • Bump version number to 1.3.2

@ferranabello
- Make getNavigationController function public
cca02b1 
- Use router's viewController accessor instead of force casting
- Extend RouterProtocol instead of Router class if it makes sense
- Bump version number to 1.3.2
@codecov
Copy link

codecov bot commented May 17, 2019 •
edited
Loading

Codecov Report

Merging #103 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #103      +/-   ##
==========================================
- Coverage    98.2%   98.19%   -0.02%     
==========================================
  Files           7        7              
  Lines         167      166       -1     
==========================================
- Hits          164      163       -1     
  Misses          3        3
Impacted Files Coverage Δ
Viperit/Core/Router.swift 94.33% <100%> (-0.11%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b54c781...cca02b1. Read the comment docs.

@ferranabello ferranabello merged commit 961052d into master May 17, 2019
@ferranabello ferranabello deleted the feature/router branch May 17, 2019 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ferranabello