Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Repair criticalup run in Windows #17

Merged
merged 4 commits into from
May 24, 2024
Merged

Repair criticalup run in Windows #17

merged 4 commits into from
May 24, 2024

Conversation

Hoverbear
Copy link
Member

cargo run does not invoke rustc.exe, it invokes rustc. 😅

@Hoverbear Hoverbear self-assigned this May 24, 2024
@Hoverbear Hoverbear marked this pull request as ready for review May 24, 2024 13:56
@Hoverbear Hoverbear requested a review from pietroalbini May 24, 2024 13:56
pietroalbini
pietroalbini previously approved these changes May 24, 2024
View reviewed changes
Copy link
Member

@pietroalbini pietroalbini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

bors-ferrocene bot added a commit that referenced this pull request May 24, 2024
@bors-ferrocene @Hoverbear
Merge #17
b9f3c20 
17: Repair criticalup run in Windows r=pietroalbini a=Hoverbear

`cargo run` does not invoke `rustc.exe`, it invokes `rustc`. 😅 

Co-authored-by: Ana Hobden <operator@hoverbear.org>
@bors-ferrocene
Copy link
Contributor

Build failed:

pietroalbini
pietroalbini approved these changes May 24, 2024
View reviewed changes
Copy link
Member

@pietroalbini pietroalbini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

@bors-ferrocene
Copy link
Contributor

Build succeeded:

  • CI build successful

@Hoverbear Hoverbear merged commit a49bf02 into main May 24, 2024
13 checks passed
@bors-ferrocene bors-ferrocene bot deleted the hoverbear/fix-criticalup-run-in-windows branch May 24, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pietroalbini pietroalbini pietroalbini approved these changes

@miguelraz miguelraz miguelraz approved these changes

Assignees

@Hoverbear Hoverbear

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Hoverbear @pietroalbini @miguelraz