111 use defmt logging #140
Conversation
Lotterleben
force-pushed
the
111-use-defmt-logging
branch
from
653961e
to
e1f740c
Compare
| dk::exit() | ||
| } | ||
| } | ||
|
|
||
| log::info!("{:?}", dict); | ||
| defmt::info!("{:?}", defmt::Debug2Format(&dict)); | ||
| // ^^^^^^^^^^^^^^^^^^^ this adapter iscurrently needed to log `heapless` |
There was a problem hiding this comment.
can't implement this for heapless due to circular dependency conundrum, see rust-embedded/heapless#172 (comment)
There was a problem hiding this comment.
heapless 0.7.1 has defmt support (behind a Cargo feature); also const generics 🎉 . we should move to that version ASAP
There was a problem hiding this comment.
nice! From what I see, it doesn't impl Format for LinearMaps though, right? PR incoming...
Lotterleben
force-pushed
the
111-use-defmt-logging
branch
from
b78b81d
to
f3c7327
Compare
Lotterleben
force-pushed
the
111-use-defmt-logging
branch
from
bdb5be0
to
f8db981
Compare
| @@ -87,7 +88,9 @@ fn ep0setup(usbd: &USBD, ep0in: &mut Ep0In, state: &mut State) -> Result<(), ()> | |||
|
|
|||
| let request = Request::parse(bmrequesttype, brequest, wvalue, windex, wlength) | |||
| .expect("Error parsing request"); | |||
| log::info!("EP0: {:?}", request); | |||
| defmt::info!("EP0: {:?}", defmt::Debug2Format(&request)); | |||
There was a problem hiding this comment.
feel free to send a PR to usb2 to add derive(Format) to these structs. I can quickly merge that and put out a new crates.io release
There was a problem hiding this comment.
note for anyone picking this up: I've done most of the work for this here, but at the time it was blocked on knurling-rs/defmt#501
because I couldn't simply derive or impl Format for it from there because it's not part of my crate. This has since been resolved with the above issue being closed
| let mut dict = LinearMap::<_, _, consts::U2>::new(); | ||
| // ^^ capacity; this is a type not a value | ||
| let mut dict = LinearMap::<_, _, 2>::new(); | ||
| // content types ^^ ^^ ^ capacity |
There was a problem hiding this comment.
these markers (in the comment) no longer match the preceding line of code -- this happens in other files as well
There was a problem hiding this comment.
ah dangit. they only match if you're using Rust-Analyzer. I wonder how to best resolve this
There was a problem hiding this comment.
the original assumes you are not viewing the code with Rust-Analyzer's annotations so perhaps we can leave it like that? The other option I can think of is discarding the marker and instead describing the type parameters with text in a preceding comment (first param is X, second is Y, etc.)
…stems/embedded-trainings-2020 into 111-use-defmt-logging
…stems/embedded-trainings-2020 into 111-use-defmt-logging
NOTE: I have currently abandoned this for time reasons. If you're reading this and would like to finish it, feel free to take it over.
opening as draft PR for visibility (fixes #111 when finished)
TODO
Notes:
stack_overflow example yields
according to my debugger step-through this is printed as a result of probe-run's
symtabfallback: https://github.com/knurling-rs/probe-run/blob/main/src/main.rs#L769