Replace mermaid with Graphviz #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Requires updated mdslides binary.
TODO: Needs update mdslides release that understands these new graphviz diagrams.
Deploying ferrous-systems-rust-training with
|
| Latest commit: |
fd892d1
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://e958c987.ferrous-systems-rust-training.pages.dev |
| Branch Preview URL: | https://remove-mermaid.ferrous-systems-rust-training.pages.dev |
Ugh, why zip?
jonathanpallant
force-pushed
the
remove-mermaid
branch
from
d0b1af7 to
00d21f1
Compare
jonathanpallant
force-pushed
the
remove-mermaid
branch
from
244a495 to
d555595
Compare
Also switch lightgreen to green3, because this old version of dot doesn't know what "lightgreen" is.
jonathanpallant
force-pushed
the
remove-mermaid
branch
from
2e40caf to
602e287
Compare
|
|
listochkin
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces mermaid diagrams with Graphviz.
This means we can render them in advance in mdslides, and avoid the weird rendering but that means diagrams often won't even display correctly.
I did try a mermaid renderer in ferrous-systems/mdslides#23 but it requires headless Chrome, and you can't control the theme.
Uses mdslides 0.5.0, which converts
```dot processcode blocks into SVG.