Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate and rename "scope" parameter and introduce real scope filtering #107

Closed
ferstl opened this issue Dec 24, 2019 · 0 comments
Closed

Deprecate and rename "scope" parameter and introduce real scope filtering #107

ferstl opened this issue Dec 24, 2019 · 0 comments
Assignees
@ferstl
Labels
new feature on-master
Milestone
4.0.0

Comments

@ferstl
Copy link
Owner

ferstl commented Dec 24, 2019

The name of the scope parameter is a bit misleading since it effectively considers the classpath that is visible for the defined scope. This should be changed as follows:

  • deprecate the scope parameter and introduce a new parameter classpathScope with the same semantics
  • create a new scopes (note the s) parameter that allows filtering for real scopes
@ferstl ferstl self-assigned this Dec 24, 2019
@ferstl ferstl added this to the 4.0.0 milestone Dec 24, 2019
@ferstl ferstl mentioned this issue Dec 24, 2019
Closed
ferstl added a commit that referenced this issue Dec 25, 2019
@ferstl
#107 Deprecate the scope parameter and replace it with `classpathSc…
8a465c8 
…ope`
ferstl added a commit that referenced this issue Dec 25, 2019
@ferstl
#107 Allow empty scopes in DependencyNode
31408b4 
- DependencyNode#getScopes() may return an empty set
- DependencyNode#getEffectiveScope() returns "compile" if no scope was defined
- DependencyNodeIdRenderer uses "compile" if no scope was defined
- All NodeNameRenderers need to handle empty scopes by themselfes

Signed-off-by: Stefan Ferstl <st.ferstl@gmail.com>
ferstl added a commit that referenced this issue Dec 25, 2019
@ferstl
#107 Introduce new scopes parameter to filter for dependency scopes
325f502 
The `classpathScope` parameter will be ignored if the `scopes` parameter is set.

Signed-off-by: Stefan Ferstl <st.ferstl@gmail.com>
@coveralls coveralls mentioned this issue Dec 25, 2019
Merged
ferstl added a commit that referenced this issue Dec 25, 2019
@ferstl
Merge pull request #108 from ferstl/feature/#107-improve-scope-handling
454edda 
Feature/#107 improve scope handling
@ferstl ferstl closed this as completed Jan 12, 2022
@fernandosci fernandosci mentioned this issue Feb 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ferstl ferstl

Labels
new feature on-master
Projects
None yet
Milestone
4.0.0
Development

No branches or pull requests
1 participant
@ferstl