Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

includes in not support #84

Closed
wangwei-ying opened this issue Sep 25, 2018 · 1 comment
Closed

includes in not support #84

wangwei-ying opened this issue Sep 25, 2018 · 1 comment

Comments

@wangwei-ying
Copy link

<plugins> <plugin> <groupId>com.github.ferstl</groupId> <artifactId>depgraph-maven-plugin</artifactId> <configuration> <includes> <include>org.framework:*</include> </includes> </configuration> <version>3.2.1</version> </plugin> </plugins>

I get

`digraph "sendinfo-admin" {
node [shape="box",style="rounded",fontname="Helvetica",fontsize="14"]
edge [fontsize="10",fontname="Helvetica"]

// Node Definitions:

// Edge Definitions:
}`

when I delete includes like this
<plugin> <groupId>com.github.ferstl</groupId> <artifactId>depgraph-maven-plugin</artifactId> <configuration> <!--<includes>--> <!--<include>org.framework:*</include>--> <!--</includes>--> </configuration> <version>3.2.1</version> </plugin>

I get

`digraph "sendinfo-admin" {
node [shape="box",style="rounded",fontname="Helvetica",fontsize="14"]
edge [fontsize="10",fontname="Helvetica"]

// Node Definitions:
"com.sendinfo.framework:sendinfo-core:jar"[label=]
"org.apache.commons:commons-lang3:jar"[label=]
"com.sendinfo.framework:sendinfo-springmvc:jar"[label=]
"org.springframework.data:spring-data-keyvalue:jar"[label=]
"org.springframework.data:spring-data-commons:jar"[label=]
"org.springframework.data:spring-data-redis:jar"[label=]
"org.springframework:spring-tx:jar"[label=]
"org.springframework:spring-oxm:jar"[label=]
"org.slf4j:jcl-over-slf4j:jar"[label=]
"com.sendinfo.framework:sendinfo-redis:jar"[label=]
"redis.clients:jedis:jar"[label=]
"org.apache.commons:commons-pool2:jar"[label=]
"com.dyuproject.protostuff:protostuff-core:jar"[label=]
"com.dyuproject.protostuff:protostuff-api:jar"[label=]
"com.dyuproject.protostuff:protostuff-runtime:jar"[label=]
"com.dyuproject.protostuff:protostuff-collectionschema:jar"[label=]
"io.undertow:undertow-core:jar"[label=]
"org.jboss.xnio:xnio-api:jar"[label=]
"org.jboss.xnio:xnio-nio:jar"[label=<xnio-nio
(runtime)>]
"org.springframework.boot:spring-boot-starter-undertow:jar"[label=]
"io.undertow:undertow-servlet:jar"[label=]
"org.jboss.spec.javax.annotation:jboss-annotations-api_1.2_spec:jar"[label=<jboss-annotations-api_1.2_spec>]
"io.undertow:undertow-websockets-jsr:jar"[label=]
"org.jboss.spec.javax.websocket:jboss-websocket-api_1.1_spec:jar"[label=<jboss-websocket-api_1.1_spec>]
"javax.servlet:javax.servlet-api:jar"[label=<javax.servlet-api
(provided)>]
"org.glassfish:javax.el:jar"[label=<javax.el>]`

@ferstl ferstl added the bug label Sep 26, 2018
@ferstl ferstl added this to the 3.2.2 milestone Sep 26, 2018
ferstl added a commit that referenced this issue Sep 26, 2018
In case the global filter excludes a node, graph traversal should
continue. Otherwise dependencies that are not excluded will not be
visited at all.
ferstl added a commit that referenced this issue Sep 26, 2018
In case the global filter excludes a node, graph traversal should
continue. Otherwise dependencies that are not excluded will not be
visited at all.
ferstl added a commit that referenced this issue Sep 26, 2018
@ferstl
Copy link
Owner

ferstl commented Sep 26, 2018

Hi,

Release 3.2.2 fixes this issue. It should be available on Maven Central within the next few hours. Please be aware that your include filter org.framework:* will only match dependencies with the exact groupId org.springframework. If you want to also have spring-boot or spring-data in your dependency graph, you need to adjust your filter to either org.springframework.*:* or org.springframework*:*

@ferstl ferstl closed this as completed Sep 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants