This repository has been archived by the owner on Aug 24, 2022. It is now read-only.
DKG Evidence #205
Merged
DKG Evidence #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n-hutton
reviewed
Oct 13, 2020
beacon/beacon_setup_service.cpp
Outdated
| @@ -530,5 +530,12 @@ bool BeaconSetupService::CheckQualComplaints() | |||
| return true; | |||
| } | |||
|
|
|||
| bool BeaconSetupService::InQual(Identifier index) { | |||
There was a problem hiding this comment.
What type is Identifier here? It's being copied into the function, I also am not sure of what the reason is for constructing set from the set that comes back from beacon->qual(). BaseDkg already has an InQual method?
There was a problem hiding this comment.
It's the validator index so uint32 which is why I didn't bother passing it by reference. Thanks, I didn't realise BaseDkg has a InQual method. I will change it so that it uses that.
n-hutton
approved these changes
Oct 14, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: collection of complaint answers has changed and node's now have to wait for their own message to appear in a block before they include it. This is to ensure that everyone generates evidence at the same height.