This repository has been archived by the owner on Aug 24, 2022. It is now read-only.
Verify combined signature in light client #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jinmannwong
commented
Nov 3, 2020
jinmannwong
commented
- Remove validation of vote signature in light client and replace with combined signature verification
jinmannwong
commented
Nov 3, 2020
| var ( | ||
| benchmarkFullNode = mockp.New(GenMockNode(chainID, 1000, 100, 1, bTime)) | ||
| genesisHeader, _ = benchmarkFullNode.SignedHeader(1) | ||
| ) |
There was a problem hiding this comment.
Made these local inside benchmark functions as they take a long time to create and are not required for tests.
jinmannwong
commented
Nov 3, 2020
| @@ -651,75 +651,6 @@ func TestValidatorSet_VerifyCommit(t *testing.T) { | |||
| } | |||
| } | |||
|
|
|||
| // Check VerifyCommitLight and VerifyCommitLightTrusting basic | |||
| // verification. | |||
| func TestValidatorSet_VerifyCommit_All(t *testing.T) { | |||
There was a problem hiding this comment.
Function tested no longer exists
jinmannwong
commented
Nov 3, 2020
| // | ||
| // This method is primarily used by the light client and does not check all the | ||
| // signatures. | ||
| func (vals *ValidatorSet) VerifyCommitLight(chainID string, blockID BlockID, |
There was a problem hiding this comment.
Removed so that light clients use VerifyCommit
n-hutton
approved these changes
Nov 4, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.