refactor: change test return type for concurrency #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Josumner
requested review from
daeMOn63 and
ejfitzgerald
and removed request for
daeMOn63
daeMOn63
previously approved these changes
Jul 19, 2021
There was a problem hiding this comment.
Looks good 👍
Just a small nit comment, since expResponse is mostly passed around as a pointer, it's probably best to just return a pointer from the start. No big deal in this context outside of some little code clarity improvement and negligible perf gain. The main interest appears with bigger structs, as returning a pointer reference would avoid some stack allocations and copies that are done when returning the actual struct.
x/airdrop/keeper/grpc_query_test.go
Outdated
| testCases := []struct { | ||
| msg string | ||
| malleate func() | ||
| testFunc func() (*types.QueryAllFundsRequest, types.QueryAllFundsResponse) |
There was a problem hiding this comment.
why not returning a *types.QueryAllFundsResponse here ?
There was a problem hiding this comment.
Well spotted, I didn't meant to implement it in that way
daeMOn63
approved these changes
Jul 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.