integration/capricorn

.github/workflows/test.yml

@@ -35,7 +35,8 @@ jobs:
  runs-on: ubuntu-latest
  strategy:
  matrix:
- go-arch: ["amd64", "arm", "arm64"]
+ # dropped arm because of bls
+ go-arch: ["amd64"] #, "arm", "arm64"]
  steps:
  - uses: actions/checkout@v2
  - uses: actions/setup-go@v2.1.3

CHANGELOG.md

@@ -36,14 +36,54 @@ Ref: https://keepachangelog.com/en/1.0.0/
 
 ## Unreleased
 
+## [v0.42.11](https://github.com/cosmos/cosmos-sdk/releases/tag/v0.42.11) - 2021-12-07
+
+### Improvements
+
+* (types) [\#10630](https://github.com/cosmos/cosmos-sdk/pull/10630) Add an `Events` field to the `TxResponse` type that captures _all_ events emitted by a transaction, unlike `Logs` which only contains events emitted during message execution.
+* [\#10327](https://github.com/cosmos/cosmos-sdk/pull/10327) Add null guard for possible nil `Amount` in tx fee `Coins`
+* [\#10339](https://github.com/cosmos/cosmos-sdk/pull/10339) Improve performance of `removeZeroCoins` by only allocating memory when necessary
+* (deps) [\#10376](https://github.com/cosmos/cosmos-sdk/pull/10376) Bump Tendermint to [v0.34.14](https://github.com/tendermint/tendermint/releases/tag/v0.34.14).
+* (deps) [\#10654](https://github.com/cosmos/cosmos-sdk/pull/10654) Bump IAVL version to 0.17.3.
+* (deps) [\#10201](https://github.com/cosmos/cosmos-sdk/pull/10201) Migrate from `enigmampc/btcutil` to `cosmos/btcutil`.
+
+
+### Bug Fixes
+
+* (client) [#10226](https://github.com/cosmos/cosmos-sdk/pull/10226) Fix --home flag parsing.
+
+### Client Breaking Changes
+
+* [\#10394](https://github.com/cosmos/cosmos-sdk/issues/10394) Fixes issue related to grpc-gateway of account balance by ibc-denom. Please use `/cosmos/bank/v1beta1/balances/{address}/by_denom?denom={DENOM or IBC-DENOM}` for querying balances by denom.
+
+## [v0.42.10](https://github.com/cosmos/cosmos-sdk/releases/tag/v0.42.10) - 2021-09-28
+
+### Improvements
+
+* (store) [\#10026](https://github.com/cosmos/cosmos-sdk/pull/10026) Improve CacheKVStore datastructures / algorithms, to no longer take O(N^2) time when interleaving iterators and insertions.
+* (store) [\#10040](https://github.com/cosmos/cosmos-sdk/pull/10040) Bump IAVL to v0.17.1 which includes performance improvements on a batch load.
+* [\#10211](https://github.com/cosmos/cosmos-sdk/pull/10211) Backport of the mechanism to reject redundant IBC transactions from [ibc-go \#235](https://github.com/cosmos/ibc-go/pull/235).
+
+### Bug Fixes
+
+* [\#9969](https://github.com/cosmos/cosmos-sdk/pull/9969) fix: use keyring in config for add-genesis-account cmd.
+* [\#10061](https://github.com/cosmos/cosmos-sdk/pull/10061) Ensure that `LegacyAminoPubKey` struct correctly unmarshals from JSON
+
+### Client Breaking Changes
+
+* [\#9879](https://github.com/cosmos/cosmos-sdk/pull/9879) Modify ABCI Queries to use `abci.QueryRequest` Height field if it is non-zero, otherwise continue using context height.
+
+### API Breaking Changes
+
++ [\#10077](https://github.com/cosmos/cosmos-sdk/pull/10077) Remove telemetry on `GasKV` and `CacheKV` store Get/Set operations, significantly improving their performance.
+
 ## [v0.42.9](https://github.com/cosmos/cosmos-sdk/releases/tag/v0.42.9) - 2021-08-04
 
 ### Bug Fixes
 
 * [\#9835](https://github.com/cosmos/cosmos-sdk/pull/9835) Moved capability initialization logic to BeginBlocker to fix nondeterminsim issue mentioned in [\#9800](https://github.com/cosmos/cosmos-sdk/issues/9800). Applications must now include the capability module in their BeginBlocker order before any module that uses capabilities gets run.
 * [\#9201](https://github.com/cosmos/cosmos-sdk/pull/9201) Fixed `<app> init --recover` flag.
 
-
 ### API Breaking Changes
 
 * [\#9835](https://github.com/cosmos/cosmos-sdk/pull/9835) The `InitializeAndSeal` API has not changed, however it no longer initializes the in-memory state. `InitMemStore` has been introduced to serve this function, which will be called either in `InitChain` or `BeginBlock` (whichever is first after app start). Nodes may run this version on a network running 0.42.x, however, they must update their app.go files to include the capability module in their begin blockers.
@@ -60,6 +100,7 @@ Ref: https://keepachangelog.com/en/1.0.0/
 
 ### Improvements
 
+* (deps) [\#9956](https://github.com/cosmos/cosmos-sdk/pull/9956) Bump Tendermint to [v0.34.12](https://github.com/tendermint/tendermint/releases/tag/v0.34.12).
 * (cli) [\#9717](https://github.com/cosmos/cosmos-sdk/pull/9717) Added CLI flag `--output json/text` to `tx` cli commands.
 
 ### Bug Fixes

Makefile

@@ -241,9 +241,9 @@ $(CHECK_TEST_TARGETS): run-tests
 
 run-tests:
 ifneq (,$(shell which tparse 2>/dev/null))
- go test -mod=readonly -json $(ARGS) $(EXTRA_ARGS) $(TEST_PACKAGES) | tparse
+ go test -count=1 -mod=readonly -json $(ARGS) $(EXTRA_ARGS) $(TEST_PACKAGES) | tparse
 else
- go test -mod=readonly $(ARGS) $(EXTRA_ARGS) $(TEST_PACKAGES)
+ go test -count=1 -mod=readonly $(ARGS) $(EXTRA_ARGS) $(TEST_PACKAGES)
 endif
 
 .PHONY: run-tests test test-all $(TEST_TARGETS)
@@ -396,10 +396,10 @@ proto-format:
  find ./ -not -path "./third_party/*" -name *.proto -exec clang-format -i {}; fi
 
 proto-lint:
- @$(DOCKER_BUF) check lint --error-format=json
+ @$(DOCKER_BUF) lint --error-format=json
 
 proto-check-breaking:
- @$(DOCKER_BUF) check breaking --against-input $(HTTPS_GIT)#branch=master
+ @$(DOCKER_BUF) breaking --against-input $(HTTPS_GIT)#branch=master
 
 
 TM_URL = https://raw.githubusercontent.com/tendermint/tendermint/v0.34.0-rc6/proto/tendermint

RELEASE_NOTES.md

@@ -1,10 +1,19 @@
-# Cosmos SDK v0.42.9 "Stargate" Release Notes
+# Cosmos SDK v0.42.11 "Stargate" Release Notes
 
-This release includes an important `x/capabiliy` module bug fix for 0.42.7 and 0.42.8 which prohibits IBC to create new channels (issuse [\#9800](https://github.com/cosmos/cosmos-sdk/issues/9800)).
-The fix changes the `x/capability/keeper/Keeper.InitializeAndSeal` method behavior and requires to update an app module manager by adding x/capability module to Begin Blockers.
+This release includes a client-breaking change for HTTP users querying account balances by denom:
 
-We also fixed `<app> init --recovery` mode where the mnemonic was not handled correctly.
+```diff
+- <base_url>/cosmos/bank/v1beta1/balances/<address>/<denom>
++ <base_url>/cosmos/bank/v1beta1/balances/<address>/by_denom?denom=<denom>
+```
 
-We also changed `<app> tx distribution withdraw-all-rewards` CLI by forcing the broadcast mode if a chunk size is greater than 0. This will ensure that the transactions do not fail even if the user uses invalid broadcast modes for this command (sync and async). This was requested by the community and we consider it as fixing the `withdraw-all-rewards` behavior.
+This change was made to fix querying IBC denoms via HTTP.
 
-See the [Cosmos SDK v0.42.9 milestone](https://github.com/cosmos/cosmos-sdk/milestone/53?closed=1) on our issue tracker for the exhaustive list of all changes.
+v0.42.11 also includes multiple bugfixes and performance improvements, such as:
+
+- Upgrade IAVL to 0.17.3 to solve race condition bug in IAVL.
+- Bump Tendermint to [v0.34.14](https://github.com/tendermint/tendermint/releases/tag/v0.34.14).
+
+Finally, when querying for transactions, we added an `Events` field to the `TxResponse` type that captures _all_ events emitted by a transaction, unlike `Logs` which only contains events emitted during message execution. `Logs` and `Events` may currently contain duplicate data, but `Logs` will be deprecated in a future version.
+
+See our [CHANGELOG](./CHANGELOG.md) for the exhaustive list of all changes, or a full [commit diff](https://github.com/cosmos/cosmos-sdk/compare/v0.42.09...v0.42.10).

client/cmd.go

@@ -245,21 +245,6 @@ func readTxCommandFlags(clientCtx Context, flagSet *pflag.FlagSet) (Context, err
  return clientCtx, nil
 }
 
-// ReadHomeFlag checks if home flag is changed.
-// If this is a case, we update HomeDir field of Client Context
-/* Discovered a bug with Cory
-./build/simd init andrei --home ./test
-cd test/config there is no client.toml configuration file
-*/
-func ReadHomeFlag(clientCtx Context, cmd *cobra.Command) Context {
- if cmd.Flags().Changed(flags.FlagHome) {
- rootDir, _ := cmd.Flags().GetString(flags.FlagHome)
- clientCtx = clientCtx.WithHomeDir(rootDir)
- }
-
- return clientCtx
-}
-
 // GetClientQueryContext returns a Context from a command with fields set based on flags
 // defined in AddQueryFlagsToCmd. An error is returned if any flag query fails.
 //

client/context.go

@@ -1,6 +1,7 @@
 package client
 
 import (
+ "bufio"
  "encoding/json"
  "io"
  "os"
@@ -60,7 +61,10 @@ func (ctx Context) WithKeyring(k keyring.Keyring) Context {
 
 // WithInput returns a copy of the context with an updated input.
 func (ctx Context) WithInput(r io.Reader) Context {
- ctx.Input = r
+ // convert to a bufio.Reader to have a shared buffer between the keyring and the
+ // the Commands, ensuring a read from one advance the read pointer for the other.
+ // see https://github.com/cosmos/cosmos-sdk/issues/9566.
+ ctx.Input = bufio.NewReader(r)
  return ctx
 }
 

client/grpc_query.go

@@ -112,8 +112,9 @@ func RunGRPCQuery(ctx Context, grpcCtx gocontext.Context, method string, req int
  }
 
  abciReq := abci.RequestQuery{
- Path: method,
- Data: reqBz,
+ Path: method,
+ Data: reqBz,
+ Height: ctx.Height,
  }
 
  abciRes, err := ctx.QueryABCI(abciReq)

client/keys/add_test.go

@@ -1,7 +1,6 @@
 package keys
 
 import (
- "bufio"
  "context"
  "fmt"
  "testing"
@@ -124,7 +123,7 @@ func TestAddRecoverFileBackend(t *testing.T) {
  mockIn := testutil.ApplyMockIODiscardOutErr(cmd)
  kbHome := t.TempDir()
 
- clientCtx := client.Context{}.WithKeyringDir(kbHome).WithInput(bufio.NewReader(mockIn))
+ clientCtx := client.Context{}.WithKeyringDir(kbHome).WithInput(mockIn)
  ctx := context.WithValue(context.Background(), client.ClientContextKey, &clientCtx)
 
  cmd.SetArgs([]string{

client/keys/export_test.go

@@ -1,7 +1,7 @@
 package keys
 
 import (
- "bytes"
+ "bufio"
  "context"
  "fmt"
  "testing"
@@ -18,58 +18,95 @@ import (
 )
 
 func Test_runExportCmd(t *testing.T) {
- cmd := ExportKeyCommand()
- cmd.Flags().AddFlagSet(Commands("home").PersistentFlags())
- mockIn := testutil.ApplyMockIODiscardOutErr(cmd)
-
- // Now add a temporary keybase
- kbHome := t.TempDir()
-
- // create a key
- kb, err := keyring.New(sdk.KeyringServiceName(), keyring.BackendTest, kbHome, nil)
- require.NoError(t, err)
- t.Cleanup(func() {
- kb.Delete("keyname1") // nolint:errcheck
- })
-
- path := sdk.GetConfig().GetFullFundraiserPath()
- _, err = kb.NewAccount("keyname1", testutil.TestMnemonic, "", path, hd.Secp256k1)
- require.NoError(t, err)
-
- // Now enter password
- args := []string{
- "keyname1",
- fmt.Sprintf("--%s=%s", flags.FlagHome, kbHome),
- fmt.Sprintf("--%s=%s", flags.FlagKeyringBackend, keyring.BackendTest),
+ testCases := []struct {
+ name string
+ keyringBackend string
+ extraArgs []string
+ userInput string
+ mustFail bool
+ expectedOutput string
+ }{
+ {
+ name: "--unsafe only must fail",
+ keyringBackend: keyring.BackendTest,
+ extraArgs: []string{"--unsafe"},
+ mustFail: true,
+ },
+ {
+ name: "--unarmored-hex must fail",
+ keyringBackend: keyring.BackendTest,
+ extraArgs: []string{"--unarmored-hex"},
+ mustFail: true,
+ },
+ {
+ name: "--unsafe --unarmored-hex fail with no user confirmation",
+ keyringBackend: keyring.BackendTest,
+ extraArgs: []string{"--unsafe", "--unarmored-hex"},
+ userInput: "",
+ mustFail: true,
+ expectedOutput: "",
+ },
+ {
+ name: "--unsafe --unarmored-hex succeed",
+ keyringBackend: keyring.BackendTest,
+ extraArgs: []string{"--unsafe", "--unarmored-hex"},
+ userInput: "y\n",
+ mustFail: false,
+ expectedOutput: "2485e33678db4175dc0ecef2d6e1fc493d4a0d7f7ce83324b6ed70afe77f3485\n",
+ },
+ {
+ name: "file keyring backend properly read password and user confirmation",
+ keyringBackend: keyring.BackendFile,
+ extraArgs: []string{"--unsafe", "--unarmored-hex"},
+ // first 2 pass for creating the key, then unsafe export confirmation, then unlock keyring pass
+ userInput: "12345678\n12345678\ny\n12345678\n",
+ mustFail: false,
+ expectedOutput: "2485e33678db4175dc0ecef2d6e1fc493d4a0d7f7ce83324b6ed70afe77f3485\n",
+ },
  }
 
- mockIn.Reset("123456789\n123456789\n")
- cmd.SetArgs(args)
-
- clientCtx := client.Context{}.
- WithKeyringDir(kbHome).
- WithKeyring(kb).
- WithInput(mockIn)
- ctx := context.WithValue(context.Background(), client.ClientContextKey, &clientCtx)
-
- require.NoError(t, cmd.ExecuteContext(ctx))
-
- argsUnsafeOnly := append(args, "--unsafe")
- cmd.SetArgs(argsUnsafeOnly)
- require.Error(t, cmd.ExecuteContext(ctx))
-
- argsUnarmoredHexOnly := append(args, "--unarmored-hex")
- cmd.SetArgs(argsUnarmoredHexOnly)
- require.Error(t, cmd.ExecuteContext(ctx))
-
- argsUnsafeUnarmoredHex := append(args, "--unsafe", "--unarmored-hex")
- cmd.SetArgs(argsUnsafeUnarmoredHex)
- require.Error(t, cmd.ExecuteContext(ctx))
-
- mockOut := bytes.NewBufferString("")
- cmd.SetOut(mockOut)
- cmd.SetErr(mockOut)
- mockIn.Reset("y\n")
- require.NoError(t, cmd.ExecuteContext(ctx))
- require.Equal(t, "2485e33678db4175dc0ecef2d6e1fc493d4a0d7f7ce83324b6ed70afe77f3485\n", mockOut.String())
+ for _, tc := range testCases {
+ t.Run(tc.name, func(t *testing.T) {
+ kbHome := t.TempDir()
+ defaultArgs := []string{
+ "keyname1",
+ fmt.Sprintf("--%s=%s", flags.FlagHome, kbHome),
+ fmt.Sprintf("--%s=%s", flags.FlagKeyringBackend, tc.keyringBackend),
+ }
+
+ cmd := ExportKeyCommand()
+ cmd.Flags().AddFlagSet(Commands("home").PersistentFlags())
+
+ cmd.SetArgs(append(defaultArgs, tc.extraArgs...))
+ mockIn, mockOut := testutil.ApplyMockIO(cmd)
+
+ mockIn.Reset(tc.userInput)
+ mockInBuf := bufio.NewReader(mockIn)
+
+ // create a key
+ kb, err := keyring.New(sdk.KeyringServiceName(), tc.keyringBackend, kbHome, bufio.NewReader(mockInBuf))
+ require.NoError(t, err)
+ t.Cleanup(func() {
+ kb.Delete("keyname1") // nolint:errcheck
+ })
+
+ path := sdk.GetConfig().GetFullFundraiserPath()
+ _, err = kb.NewAccount("keyname1", testutil.TestMnemonic, "", path, hd.Secp256k1)
+ require.NoError(t, err)
+
+ clientCtx := client.Context{}.
+ WithKeyringDir(kbHome).
+ WithKeyring(kb).
+ WithInput(mockInBuf)
+ ctx := context.WithValue(context.Background(), client.ClientContextKey, &clientCtx)
+
+ err = cmd.ExecuteContext(ctx)
+ if tc.mustFail {
+ require.Error(t, err)
+ } else {
+ require.NoError(t, err)
+ require.Equal(t, tc.expectedOutput, mockOut.String())
+ }
+ })
+ }
 }