-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: dorado upgrade (ECO-965) #124
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update gov tx usage * Update proto * make proto-gen * Add deposit test * Rename test function * More audits * Update x/gov/keeper/internal_test.go * Update x/gov/spec/01_concepts.md Co-authored-by: atheeshp <59333759+atheeshp@users.noreply.github.com>
* ADR-30 (authz) update based on authz audit * changelog and comment update * fix linter issue * Apply suggestions from code review Co-authored-by: Marie Gauthier <marie.gauthier63@gmail.com> Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com> * Update MsgGrant to reuse the Grant type * Update docs/architecture/adr-030-authz-module.md Co-authored-by: Marie Gauthier <marie.gauthier63@gmail.com> Co-authored-by: Marie Gauthier <marie.gauthier63@gmail.com> Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com> Co-authored-by: Aaron Craelius <aaron@regen.network>
* makefile: fix proto-format * reformat all proto files * regenerating proto * remove dangling semicolon
* update example structure * update example structure * update module errors path * update paths and fix typos * update paths and fix typos * update example structure * address review comments
* adding GetAuthorization test * update MsgGrant proto * update comment
* update staking specs * use gosimple code in x/staking/client/testutil/suite.go * small fixes * add godoc to methods in msg_server and grpc_query * changes to godoc and small fixes * remove unnecessary lines * remove mentions of serviceMsg and avoid having slash after Msg
* Add ADR-042 * Fix link * Small improvements * Update link * Update docs/architecture/adr-042-group-module.md Co-authored-by: Robert Zaremba <robert@zaremba.ch> * Update docs/architecture/adr-042-group-module.md * Update docs/architecture/adr-042-group-module.md * Update docs/architecture/adr-042-group-module.md Co-authored-by: Robert Zaremba <robert@zaremba.ch> * Update docs/architecture/adr-042-group-module.md Co-authored-by: Robert Zaremba <robert@zaremba.ch> * Update docs/architecture/adr-042-group-module.md Co-authored-by: Robert Zaremba <robert@zaremba.ch> * Update docs/architecture/adr-042-group-module.md Co-authored-by: Robert Zaremba <robert@zaremba.ch> * Update docs/architecture/adr-042-group-module.md * Update docs/architecture/adr-042-group-module.md * Update docs/architecture/adr-042-group-module.md Co-authored-by: Robert Zaremba <robert@zaremba.ch> * Update docs/architecture/adr-042-group-module.md Co-authored-by: Robert Zaremba <robert@zaremba.ch> * Update docs/architecture/adr-042-group-module.md Co-authored-by: Robert Zaremba <robert@zaremba.ch> * Update docs/architecture/adr-042-group-module.md Co-authored-by: Robert Zaremba <robert@zaremba.ch> * Update docs/architecture/adr-042-group-module.md Co-authored-by: Robert Zaremba <robert@zaremba.ch> * Update docs/architecture/adr-042-group-module.md Co-authored-by: Robert Zaremba <robert@zaremba.ch> * Update docs/architecture/adr-042-group-module.md Co-authored-by: Robert Zaremba <robert@zaremba.ch> * Move orm to specific section * Update docs/architecture/adr-042-group-module.md * Update naming * Add concrete use cases * Rework ### Proposal * Rework Vote, Exec and implementation sections * Update to account for removal of ServiceMsg Co-authored-by: Alessio Treglia <alessio@tendermint.com> Co-authored-by: Robert Zaremba <robert@zaremba.ch> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Bumps [github.com/otiai10/copy](https://github.com/otiai10/copy) from 1.5.1 to 1.6.0. - [Release notes](https://github.com/otiai10/copy/releases) - [Commits](otiai10/copy@v1.5.1...v1.6.0) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
* add godoc to keeper functions * re-add ValidateBasic to MsgSend CLI tx * add comment to reflect new return value on method * remove unecessary variable * cleanup key comments * typo * unused param * update messages spec * move event emission to end of method * update keeper spec * update proto message to point correct path to interface * keeper spec typos * fix test for event emission being moved * change to blocklist * rename SendEnabledCoin(s) -> IsSendEnabledCoins * typo * remove unecessary check * move changelog line Co-authored-by: technicallyty <48813565+tytech3@users.noreply.github.com>
* fix tests * calculate fieldSize for esdca test * remove require declaration for consistency Co-authored-by: technicallyty <48813565+tytech3@users.noreply.github.com>
…248) Bumps [github.com/armon/go-metrics](https://github.com/armon/go-metrics) from 0.3.7 to 0.3.8. - [Release notes](https://github.com/armon/go-metrics/releases) - [Commits](hashicorp/go-metrics@v0.3.7...v0.3.8) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
* v043 audit changes for version * v042 audit changes for telemetry * remove version changes in telemetry audit
Co-authored-by: atheeshp <59333759+atheeshp@users.noreply.github.com> Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
* Remove migration scripts <=0.38 * Add changelog * remove more * remove more stuff * Fix test * Relase wording * Add comment * Include migratio wording
* addressing audit changes * address simulation genesis changes * address simulation operations changes * fix tests * typo * add more authorizations to operations * fix tests * fix failing simulations * WIP * WIP * testing simulations * test simulations * try fixing tests * WIP * fix error * test * Add exec authorization * WIP * WIP * fix tests * WIP * WIP * WIP * WIP * WIP * fix errors * fix test * WIP * try fix test * update tests * fix errors * add exec authorization * fix docs * fix test * fix error * try fixing simulation * fix errors * fixing simulations * fix errors * rename GenTx -> GenerateTx * Update x/authz/simulation/genesis.go Co-authored-by: Robert Zaremba <robert@zaremba.ch> * Update x/authz/simulation/genesis.go Co-authored-by: Robert Zaremba <robert@zaremba.ch> * Update x/authz/simulation/operations.go Co-authored-by: Robert Zaremba <robert@zaremba.ch> * review changes * fix tests * rename GenerateTx => GenTx * remove Authorization suffix Co-authored-by: Robert Zaremba <robert@zaremba.ch> Co-authored-by: atheeshp <59333759+atheeshp@users.noreply.github.com>
* ADR-040: Storage and SMT State Commitments * Update docs/architecture/adr-040-storage-and-smt-state-commitments.md Co-authored-by: Ismail Khoffi <Ismail.Khoffi@gmail.com> * Update docs/architecture/adr-040-storage-and-smt-state-commitments.md Co-authored-by: Ismail Khoffi <Ismail.Khoffi@gmail.com> * Added more details for snapshotting and pruning. * updated links and references * add blockchains which already use SMT * reorganize versioning and pruning * Update docs/architecture/adr-040-storage-and-smt-state-commitments.md Co-authored-by: Tomasz Zdybał <tomek@zdybal.lap.pl> * Update docs/architecture/adr-040-storage-and-smt-state-commitments.md Co-authored-by: Ismail Khoffi <Ismail.Khoffi@gmail.com> * adding a paragraph about state management * adr-40: update 'accessing old state' section * update based on all recent discussions and validations * adding more explanation about KV interface * Apply suggestions from code review Co-authored-by: Tomasz Zdybał <tomek@zdybal.lap.pl> Co-authored-by: Marko <marbar3778@yahoo.com> * Apply suggestions from code review Co-authored-by: Marko <marbar3778@yahoo.com> * review comments * adding paragraph about commiting to an object without storying it * review updates * Apply suggestions from code review Co-authored-by: Roy Crihfield <30845198+roysc@users.noreply.github.com> * review udpates * adding clarification Co-authored-by: Ismail Khoffi <Ismail.Khoffi@gmail.com> Co-authored-by: Tomasz Zdybał <tomek@zdybal.lap.pl> Co-authored-by: Marko <marbar3778@yahoo.com> Co-authored-by: Roy Crihfield <30845198+roysc@users.noreply.github.com>
Co-authored-by: Lazar Ivanovic <livanovic@happiestbaby.com>
* Update auth antehandler spec * Update x/auth/spec/03_antehandlers.md Co-authored-by: Ryan Christoffersen <12519942+ryanchrypto@users.noreply.github.com> * Update x/auth/spec/03_antehandlers.md Co-authored-by: Ryan Christoffersen <12519942+ryanchrypto@users.noreply.github.com> * Update x/auth/spec/03_antehandlers.md Co-authored-by: Ryan Christoffersen <12519942+ryanchrypto@users.noreply.github.com> * Use 1 line * Use backticks * Use consistent tx naming * Fix grammar * Update module naming * Update x/auth/spec/03_antehandlers.md Co-authored-by: Tyler <48813565+technicallyty@users.noreply.github.com> Co-authored-by: Tyler <48813565+technicallyty@users.noreply.github.com> Co-authored-by: Ryan Christoffersen <12519942+ryanchrypto@users.noreply.github.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
* Fixed parse key issue * Added getconfig in root command * uncommented changes in parse.go
* doc: Updates related to ServiceMsg, sdk.Msg and Msg service * Apply suggestions from code review Co-authored-by: Ryan Christoffersen <12519942+ryanchrypto@users.noreply.github.com> * remove one more ServiceMsg * Use service method rathr than service RPC Co-authored-by: Ryan Christoffersen <12519942+ryanchrypto@users.noreply.github.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
…(#9075) * first draft * unable to cast to simtypes.Account * fix test * add for loop in TestSimulateModuleAccountMsgSend * TestSimulateModuleAccountMsgMultiSend * refactoring, r4r * change fromSimAcc, toSimAcc to from,to respectively * Update x/bank/simulation/operations.go Co-authored-by: Robert Zaremba <robert@zaremba.ch> * Update x/bank/simulation/operations.go Co-authored-by: Robert Zaremba <robert@zaremba.ch> * getModuleAccounts * fix for loop * applied reviewers suggestions, r4r * Update x/bank/simulation/operations.go Co-authored-by: Robert Zaremba <robert@zaremba.ch> * minor changes * fix typo * all simulation package tests pass, r4r Co-authored-by: anilCSE <anil@vitwit.com> Co-authored-by: Robert Zaremba <robert@zaremba.ch> Co-authored-by: Cory <cjlevinson@gmail.com> Co-authored-by: Aaron Craelius <aaron@regen.network> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>
* feat: update rosetta sdk to v0.6.10 embed from v1.0.0 release branch of the library: https://github.com/tendermint/cosmos-rosetta-gateway/tree/release/v1.0.0 closes: cosmos/cosmos-sdk#9300 Co-authored-by: Alessio Treglia <alessio@tendermint.com>
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
…(#9340) Bumps [github.com/prometheus/common](https://github.com/prometheus/common) from 0.23.0 to 0.24.0. - [Release notes](https://github.com/prometheus/common/releases) - [Commits](prometheus/common@v0.23.0...v0.24.0) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Marko <marbar3778@yahoo.com>
Bumps [github.com/rs/zerolog](https://github.com/rs/zerolog) from 1.21.0 to 1.22.0. - [Release notes](https://github.com/rs/zerolog/releases) - [Commits](rs/zerolog@v1.21.0...v1.22.0) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Marko <marbar3778@yahoo.com>
…515) (#10872) * fix: recreate compat field, of null pubkeys in multisig (#10515) <!-- The default pull request template is for types feat, fix, or refactor. For other templates, add one of the following parameters to the url: - template=docs.md - template=other.md --> ## Description Closes: #10042 Port #10275 to master. This is addressing a regression issue for the previously merged #10061. Changelog entry and tests included in the merged #10061.
* tx result report block gas used as tx gas used Closes: #10832 Solution: Return empty GasInfo. * Update CHANGELOG.md Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>
* feat: support in-place migration ordering (#10614) ## Description Closes: #10604
* fix: use full gas on overflow (#10897) ## Description Investigating missing gas consumption
…740) (#10921) * feat!: x/gov: raise max description length to 10k chars (#10740) The 5k character limit for governance proposals is something I've ran into several times now. This feels like an artificial constraint. The deposit is our mechanism to combat spam, and extra state used for this is really not a problem. In this PR I propose raising this limit to 10k characters, to remove much of the immediate need for working around this 5k limit. <!-- The default pull request template is for types feat, fix, or refactor. For other templates, add one of the following parameters to the url: - template=docs.md - template=other.md --> ## Description Closes: #XXXX <!-- Add a description of the changes that this PR introduces and the files that are the most critical to review. -->
* revert tx when block gas limit exceeded (backport: #10770) - used a different solution. changelog * add unit test * Update baseapp/baseapp.go Co-authored-by: Robert Zaremba <robert@zaremba.ch> * simplfy the defer function Co-authored-by: Robert Zaremba <robert@zaremba.ch>
* chore: v0.45.0 Release Notes * Update * Update RELEASE_NOTES.md Co-authored-by: Robert Zaremba <robert@zaremba.ch> * Update RELEASE_NOTES.md Co-authored-by: Robert Zaremba <robert@zaremba.ch> * Update RELEASE_NOTES.md Co-authored-by: Robert Zaremba <robert@zaremba.ch> * address review Co-authored-by: Robert Zaremba <robert@zaremba.ch>
…t #10922) (#10934)
…testutil (#10956) * chore: move server.GenerateCoinKey and server.GenerateSaveCoinKey to testutil * add changelog * move testutil/known_values.go to testutil/testdata * changelog
## Description Closes: #10680
* fix: return 404 on non-existing tx (#10992) (cherry picked from commit 1581289) # Conflicts: # CHANGELOG.md * fix cl Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com> Co-authored-by: Aleksandr Bezobchuk <aleks.bezobchuk@gmail.com>
…979) * chore: update 0.45 migration and support notes (#10973) ## Description Update migration and support notes related to 0.45 release.
… (#11026) * feat!: add protection against accidental downgrades (#10407) ## Description Closes: #10318
…11107) * feat: extra logging in in-place store migrations (#10768) ## Description Closes: #10689 it'd also be good to add more fine-grained tracking of individual migrations, but there doesn't seem to be a quick way of doing it. Perhaps the best is to leave it to each migration implementation to add its own internal logging?
* 0.45.1 Release Notes * Update RELEASE_NOTES.md Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com> Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>
* chores: drop airdrop module * fix tests * chores: lint protos * fix: rosetta tests * fix: regen statik docs * fix: drop proto breakage gh action This action will never succeed since we have new proto from the version upgrade in the branch and it diff it with master. * fix: disable broken gh actions test-cosmovisor and liveness-test
Codecov Report
@@ Coverage Diff @@
## master #124 +/- ##
==========================================
- Coverage 63.02% 60.98% -2.04%
==========================================
Files 635 588 -47
Lines 41571 37637 -3934
==========================================
- Hits 26199 22953 -3246
+ Misses 12954 12742 -212
+ Partials 2418 1942 -476
|
ejfitzgerald
previously approved these changes
Mar 11, 2022
ejfitzgerald
approved these changes
Mar 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tracking branch for the dorado upgrade