feat: v0.11.4 software upgrade reconciliation #375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jonathansumner <jonathansumner98@gmail.com>
|
Visit the preview URL for this PR (updated for commit a5d7ddd): https://fetch-docs-preview--pr375-feat-v0-11-4-softwar-7edd8ch4.web.app (expires Tue, 02 Jul 2024 17:19:24 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: f2de39fd4e81249941960b74fbab0a62d90d69f8 |
Signed-off-by: jonathansumner <jonathansumner98@gmail.com>
Signed-off-by: jonathansumner <jonathansumner98@gmail.com>
Signed-off-by: jonathansumner <jonathansumner98@gmail.com>
Signed-off-by: jonathansumner <jonathansumner98@gmail.com>
pbukva
reviewed
Jun 26, 2024
pbukva
requested changes
Jun 26, 2024
There was a problem hiding this comment.
It would be good to add the manifest and save as json file. We will need to have the audit trail what was done during the upgrade (we are changing quite a lot of important bits and pieces in the chain state).
As the bonus, manifest can be used to pass the transfers from WithdrawReconciliationBalances(...) over to the ReplaceReconciliationContractState(...). Right now transfers are passed via temporarily array.
pbukva
reviewed
Jun 26, 2024
Signed-off-by: jonathansumner <jonathansumner98@gmail.com>
Signed-off-by: jonathansumner <jonathansumner98@gmail.com>
pbukva
force-pushed
the
feat/v0.11.4_software_upgrade_reconciliation_impl
branch
from
5f84d65
to
a5d7ddd
Compare
…re_upgrade_reconciliation_impl
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested for Mainnet
Untested for Dorado