Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add snap support #146

Merged
merged 3 commits into from
Apr 18, 2021
Merged

Add snap support #146

merged 3 commits into from
Apr 18, 2021

Conversation

TabulateJarl8
Copy link
Contributor

@TabulateJarl8 TabulateJarl8 commented Apr 18, 2021

I recently figured out how to use snaps, and saw that "Snap Support" was in the todo list, so I went ahead and did it. Here are instructions on how to publish it to the snap store, and feel free to change any metadata of the snap. The snap store can also automatically build and release the snap for you by connecting it to your GitHub account (https://snapcraft.io/build). Feel free to ask me any questions about the snapcraft.

@BlivionIaG
Copy link
Member

Oh I just saw the pr rn, i'll look into it tomorrow

@BlivionIaG
Copy link
Member

Well i just looked and it seams quite simple ^^.

Copy link
Member

@BlivionIaG BlivionIaG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seams alright to me, I'll do the store thing tomorrow around 10-11pm cet

@BlivionIaG BlivionIaG merged commit 867fc0e into fetchcord:master Apr 18, 2021
@TabulateJarl8 TabulateJarl8 deleted the patch-1 branch April 18, 2021 21:47
@TabulateJarl8
Copy link
Contributor Author

TabulateJarl8 commented Apr 19, 2021

I forgot to mention, if you want to release a version to the beta channel, set grade to devel in the snapcraft.yaml file and when running the snap upload command, add the --release=beta argument.

BlivionIaG added a commit that referenced this pull request Jun 10, 2021
* Add asrock motherboard support

* import fix

* version update for fix

* Fix future import bug and amd A series detection

* version update for fix

* fix packaging

* Manifest stuff

* INtel gpu fix

* Add some acer mobo

* (test) add optiplex (generic)

* oops

* ideapad test

* Add snap support (#146)

* Create snapcraft.yml

* add snap support

* fix README

* Add parrot OS config

Co-authored-by: Tabulate <tabulatejarl8@gmail.com>
BlivionIaG added a commit that referenced this pull request Aug 26, 2021
* Add parrot OS  (#153)

* Add asrock motherboard support

* import fix

* version update for fix

* Fix future import bug and amd A series detection

* version update for fix

* fix packaging

* Manifest stuff

* INtel gpu fix

* Add some acer mobo

* (test) add optiplex (generic)

* oops

* ideapad test

* Add snap support (#146)

* Create snapcraft.yml

* add snap support

* fix README

* Add parrot OS config

Co-authored-by: Tabulate <tabulatejarl8@gmail.com>

* fix windows scoop neofetch compatibility

* Update version number

* Add more mobo support and os's

* Add mageia

* Add elitedesk 800 g1

* Fix debug and add windows 11

* Add athlon silver & gold cpu support

* Prepare alt mobo detect

* [untested] motherboard fix

* Add some random acer laptop

* Add elementary os support and thinkcenter

* Disable logger

* Revert "Disable logger"

This reverts commit ff5bdc3.

	deleted:    asusmobo.txt
	deleted:    parrot.txt
	deleted:    yeet.txt

* Disable logger file

* Add terminus / elementary os terminal

* Add windows terminal

* fix windows terminal detection

Co-authored-by: Tabulate <tabulatejarl8@gmail.com>
BlivionIaG added a commit that referenced this pull request Nov 1, 2021
* Fetchcord v2.7.7 (#153) (#154)

* Add parrot OS  (#153)

* Add asrock motherboard support

* import fix

* version update for fix

* Fix future import bug and amd A series detection

* version update for fix

* fix packaging

* Manifest stuff

* INtel gpu fix

* Add some acer mobo

* (test) add optiplex (generic)

* oops

* ideapad test

* Add snap support (#146)

* Create snapcraft.yml

* add snap support

* fix README

* Add parrot OS config

Co-authored-by: Tabulate <tabulatejarl8@gmail.com>

* fix windows scoop neofetch compatibility

* Update version number

* Add more mobo support and os's

* Add mageia

* Add elitedesk 800 g1

* Fix debug and add windows 11

* Add athlon silver & gold cpu support

* Prepare alt mobo detect

* [untested] motherboard fix

* Add some random acer laptop

* Add elementary os support and thinkcenter

* Disable logger

* Revert "Disable logger"

This reverts commit ff5bdc3.

	deleted:    asusmobo.txt
	deleted:    parrot.txt
	deleted:    yeet.txt

* Disable logger file

* Add terminus / elementary os terminal

* Add windows terminal

* fix windows terminal detection

Co-authored-by: Tabulate <tabulatejarl8@gmail.com>

* Update README.md

* Update README.md

* Update README.md (#165)

* first iteration of GUI

* add launch option with --gui

* update README

Co-authored-by: Kévin Le Torc'h <kev29lt@gmail.com>
Co-authored-by: MelonMan <73000042+MelonicOverlord@users.noreply.github.com>
BlivionIaG added a commit that referenced this pull request Apr 21, 2024
* Add parrot OS  (#153)
* Add asrock motherboard support
* Fix future import bug and amd A series detection
* fix packaging
* Manifest stuff
* INtel gpu fix
* Add some acer mobo
* add optiplex (generic)
* Add snap support (#146)
* Create snapcraft.yml
* add snap support
* fix README
* fix windows scoop neofetch compatibility
* Add more mobo support and os's
* Add mageia
* Add elitedesk 800 g1
* Fix debug and add windows 11
* Add athlon silver & gold cpu support
* Prepare alt mobo detect
* Add some random acer laptop
* Add elementary os support and thinkcenter
* Disable logger
* Add terminus / elementary os terminal
* Add windows terminal
* Update README.md
* Baseline for v3
* flake8 and Cycle correction
* Adding kernel script
* Update Config.py
* MOre scripts
* Migrating jsons
* Motherboards json migration
* Minicrep
* Update os.json
* Fix unkown issues
* Improve regexes
* Add OS script for Macos and Linux + updated cpu list
* Add debug
* Remove scripts and use commands from config
* Remove lspci central db query option'
* Add better gpu detection for linux'
* Fix better gpu detection for macos'
* Add macos to the os list
* Improved terminal detection, gpu detection and cycle time config
* Fix potential issue on systems where python == python2
* Improve terminal detection
* Use custom config for neofetch
* Syntax cleanup
* Add native python query mode
* Linux specific fixes
Disable import of windows libs on non windows systems
Fix host/motherboard dection on linux
* Update Fetch.py
* Update setup.py
* Fix macos detection

---------

Co-authored-by: Tabulate <tabulatejarl8@gmail.com>
Co-authored-by: MelonMan <73000042+MelonicOverlord@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants