Remove unused multipart/mixed when there's no attachments #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The enveloppe isn't needed when we're just doing multipart/alternative Also it triggers rspamd CTYPE_MIXED_BOGUS criteria (1 point by default) Signed-off-by: Thomas Citharel <tcit@tcit.fr>
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
arnaudmorisset
approved these changes
Jul 22, 2021
|
We encountered a massive prod issue due to this multipart/mixed added at the end of these emails. Some email providers considered our emails as spam due to this, and about ~20% of our emails were affected during the month that was necessary to pinpoint this issue. |
|
👍 This explains why thunderbird shows a paperclip icon next to the message, but when clicking it, the paperclip disappears. Please merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The envelope isn't needed when we're just doing multipart/alternative with just text & html.
Also it triggers rspamd CTYPE_MIXED_BOGUS criteria (1 point by default)