Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add/remove redirect_uris to Management in GH actions #129

Merged
merged 8 commits into from
Nov 24, 2020

Conversation

Oluane
Copy link
Contributor

@Oluane Oluane commented Nov 23, 2020

Description

The goal of this PR is to implement first part of e2e tests launch in GH actions. This 1st part is about getting Vercel preview deployment's url, adding it to the test Application's redirect uris in Management and removing it.

Type of change

  • Chore (non-breaking change which refactors / improves the existing code base).
  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).

How Has This Been Tested?

List of added dependencies

Added core-fetch dependency, to have a fetch API in Node env

Checklist:

  • My code follows the style contributing guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.

@Oluane Oluane requested a review from Fuzznimp November 23, 2020 18:33
@vercel
Copy link

vercel bot commented Nov 23, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

connect-account-storybook – ./

🔍 Inspect: https://vercel.com/fewlines/connect-account-storybook/ft38zkv4j
✅ Preview: Canceled

[Deployment for 6a2f416 canceled]

fewlines-connect-account – ./

🔍 Inspect: https://vercel.com/fewlines/fewlines-connect-account/e6z0mj7uw
✅ Preview: https://fewlines-connect-a-git-cu-acrx92-ghactionsaddremoveredir-6a9ec2.fewlines.vercel.app

@vercel vercel bot temporarily deployed to Preview – connect-account-storybook November 23, 2020 18:33 Inactive
bin/addRedirectURItoConnect.ts Outdated Show resolved Hide resolved
bin/addRedirectURItoConnect.ts Outdated Show resolved Hide resolved
.github/workflows/e2e-test.yml Outdated Show resolved Hide resolved
bin/addRedirectURItoConnect.ts Outdated Show resolved Hide resolved
bin/addRedirectURItoConnect.ts Outdated Show resolved Hide resolved
lib/@types/Application.ts Outdated Show resolved Hide resolved
lib/commands/updateApplication.ts Outdated Show resolved Hide resolved
lib/queries/getApplication.ts Show resolved Hide resolved
lib/commands/updateApplication.ts Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
yarn.lock Show resolved Hide resolved
@Oluane Oluane force-pushed the CU-acrx92-GH_actions_add_remove_redirect_uris branch from 86c1899 to 6a2f416 Compare November 24, 2020 14:34
@vercel vercel bot temporarily deployed to Preview – connect-account-storybook November 24, 2020 14:34 Inactive
@Oluane Oluane merged commit 747cd78 into master Nov 24, 2020
@Oluane Oluane deleted the CU-acrx92-GH_actions_add_remove_redirect_uris branch November 24, 2020 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants