Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

samples: add the otel enable flag to new otel samples #12

Merged
merged 1 commit into from
Aug 7, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion samples/listenWithOpenTelemetryTracing.js
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ provider.addSpanProcessor(processor);
provider.register();

// Creates a client; cache this for further use.
const pubSubClient = new PubSub();
const pubSubClient = new PubSub({enableOpenTelemetryTracing: true});

async function subscriptionListen(subscriptionNameOrId) {
const subscriber = pubSubClient.subscription(subscriptionNameOrId);
Expand Down
147 changes: 0 additions & 147 deletions samples/openTelemetryTracing.js

This file was deleted.

2 changes: 1 addition & 1 deletion samples/publishWithOpenTelemetryTracing.js
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ provider.addSpanProcessor(processor);
provider.register();

// Creates a client; cache this for further use.
const pubSubClient = new PubSub();
const pubSubClient = new PubSub({enableOpenTelemetryTracing: true});

async function publishMessage(topicNameOrId, data) {
// Publishes the message as a string, e.g. "Hello, world!"
Expand Down
2 changes: 1 addition & 1 deletion samples/typescript/listenWithOpenTelemetryTracing.ts
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ provider.addSpanProcessor(processor);
provider.register();

// Creates a client; cache this for further use.
const pubSubClient = new PubSub();
const pubSubClient = new PubSub({enableOpenTelemetryTracing: true});

async function subscriptionListen(subscriptionNameOrId: string) {
const subscriber = pubSubClient.subscription(subscriptionNameOrId);
Expand Down
2 changes: 1 addition & 1 deletion samples/typescript/publishWithOpenTelemetryTracing.ts
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ provider.addSpanProcessor(processor);
provider.register();

// Creates a client; cache this for further use.
const pubSubClient = new PubSub();
const pubSubClient = new PubSub({enableOpenTelemetryTracing: true});

async function publishMessage(topicNameOrId: string, data: string) {
// Publishes the message as a string, e.g. "Hello, world!"
Expand Down
Loading