Pretty pages #533
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -1,6 +1,6 @@ | ||||||
| import { DocumentSearchIcon } from '@heroicons/react/outline' | ||||||
| import Banner from '~/components/Common/Banner' | ||||||
| import type { MetaFunction, LinksFunction } from '@remix-run/node' | ||||||
|
|
||||||
| // Overwrite default meta in the root.tsx | ||||||
| export const meta: MetaFunction = () => { | ||||||
|
|
@@ -151,20 +151,80 @@ export default function Index() { | |||||
| return ( | ||||||
| <> | ||||||
| <main className="flex-1"> | ||||||
| {/* Hero Section */} | ||||||
| <section className="relative bg-gray-900"> | ||||||
| <div className="absolute inset-0"> | ||||||
| <img | ||||||
| className="w-full h-full object-cover opacity-50" | ||||||
| src="/images/hero-bg.jpg" | ||||||
| alt="Hero Background" | ||||||
| /> | ||||||
| <div className="absolute inset-0 bg-gradient-to-r from-blue-900 via-transparent to-blue-900 opacity-70"></div> | ||||||
|
There was a problem hiding this comment. 🧹 Nitpick (assertive) Make this If there are no children, you can safely self-close: -<div className="absolute inset-0 bg-gradient-to-r from-blue-900 via-transparent to-blue-900 opacity-70"></div>
+<div className="absolute inset-0 bg-gradient-to-r from-blue-900 via-transparent to-blue-900 opacity-70" />📝 Committable suggestion
Suggested change
🧰 Tools🪛 Biome (1.9.4)[error] 162-162: JSX elements without children should be marked as self-closing. In JSX, it is valid for any element to be self-closing. Unsafe fix: Use a SelfClosingElement instead (lint/style/useSelfClosingElements) 🪛 GitHub Actions: Linters[warning] Code formatting does not match Prettier standards. Run Prettier to fix formatting issues. |
||||||
| </div> | ||||||
| <div className="relative max-w-7xl mx-auto px-4 sm:px-6 lg:px-8 py-24 text-center"> | ||||||
| <h1 className="text-5xl font-extrabold text-white"> | ||||||
| Azeroth Auction Assassin | ||||||
| </h1> | ||||||
| <p className="mt-4 text-xl text-gray-200"> | ||||||
| Lightning-fast cross-realm auction sniper - Get the best deals seconds after they appear! | ||||||
| </p> | ||||||
| <div className="mt-8 flex justify-center space-x-4"> | ||||||
| <a | ||||||
| href="https://github.com/ff14-advanced-market-search/AzerothAuctionAssassin/releases/latest" | ||||||
| target="_blank" | ||||||
| rel="noopener noreferrer" | ||||||
| className="inline-block bg-blue-600 hover:bg-blue-700 text-white font-semibold py-3 px-6 rounded-md shadow-md"> | ||||||
| Download Now | ||||||
| </a> | ||||||
| <a | ||||||
| href="https://github.com/ff14-advanced-market-search/AzerothAuctionAssassin/blob/main/README.md" | ||||||
| target="_blank" | ||||||
| rel="noopener noreferrer" | ||||||
| className="inline-block bg-blue-500 hover:bg-blue-600 text-white font-semibold py-3 px-6 rounded-md shadow-md"> | ||||||
| Learn More | ||||||
| </a> | ||||||
| </div> | ||||||
| </div> | ||||||
| </section> | ||||||
|
|
||||||
| <Banner /> | ||||||
|
|
||||||
| {/* Tools Grid Section */} | ||||||
| <section className="py-16 bg-gray-50"> | ||||||
| <div className="max-w-7xl mx-auto px-4 sm:px-6 lg:px-8"> | ||||||
| <div className="text-center mb-12"> | ||||||
| <h2 className="text-base font-semibold text-blue-600 uppercase"> | ||||||
| Tools & Features | ||||||
| </h2> | ||||||
| <p className="mt-2 text-3xl leading-8 font-extrabold tracking-tight text-gray-900 sm:text-4xl"> | ||||||
| Everything You Need for Gold Making | ||||||
| </p> | ||||||
| </div> | ||||||
|
|
||||||
| <div className="grid grid-cols-1 gap-6 sm:grid-cols-2 lg:grid-cols-3"> | ||||||
| {recommendedQueries.map((query) => ( | ||||||
| <a | ||||||
| key={query.name} | ||||||
| href={query.href} | ||||||
| target={query.external ? '_blank' : '_self'} | ||||||
| rel={query.external ? 'noopener noreferrer' : undefined} | ||||||
| className="block"> | ||||||
| <div className="h-full p-6 bg-white rounded-lg shadow-lg hover:shadow-xl transition-shadow duration-300 hover:bg-blue-50"> | ||||||
| <div className="flex items-center mb-4"> | ||||||
| <query.Icon className="h-6 w-6 text-blue-500" /> | ||||||
| <h3 className="ml-3 text-lg font-medium text-gray-900"> | ||||||
| {query.name} | ||||||
| </h3> | ||||||
| </div> | ||||||
| <p className="text-gray-600">{query.description}</p> | ||||||
| </div> | ||||||
| </a> | ||||||
| ))} | ||||||
| </div> | ||||||
| </div> | ||||||
| </section> | ||||||
|
|
||||||
|
Comment on lines
+154
to
+226
There was a problem hiding this comment. 🧹 Nitpick (assertive) Run Prettier for consistent styling. Please address the linter’s formatting warnings to ensure the code follows the project's Prettier conventions. 🧰 Tools🪛 Biome (1.9.4)[error] 162-162: JSX elements without children should be marked as self-closing. In JSX, it is valid for any element to be self-closing. Unsafe fix: Use a SelfClosingElement instead (lint/style/useSelfClosingElements) 🪛 GitHub Actions: Linters[warning] Code formatting does not match Prettier standards. Run Prettier to fix formatting issues. |
||||||
| {/* Hidden SEO content - keep existing */} | ||||||
| <p style={{ fontSize: '1px' }}> | ||||||
| Google Keywords: wow classic hardcore addons, best sod addons wow, wow | ||||||
| classic hardcore addon, wow sod addons, wow coordinates addon, wow | ||||||
|
|
||||||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧹 Nitpick (assertive)
Consider making this
divself-closing to address the static analysis hint.Since it has no children, you can safely convert:
into:
🧰 Tools
🪛 Biome (1.9.4)
[error] 151-151: JSX elements without children should be marked as self-closing. In JSX, it is valid for any element to be self-closing.
Unsafe fix: Use a SelfClosingElement instead
(lint/style/useSelfClosingElements)
🪛 GitHub Actions: Linters
[warning] Code formatting does not match Prettier standards. Run Prettier to fix formatting issues.