feat: connection led blink & strict yaml unmarshaling #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently there is no reasonable identification if the device is trying to connect or not. This will add a blinking led when device is trying to connect to network.
Unmarshaling of types that implement custom unmarshaling interface will not use that option, which in case of this configuration will lead to basically loosing that setting. go-yaml/yaml#460 This change adds strict unmarshaling, though in not ideal way. Also add test that tries to load example configurations as first test for their validity.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: blink when trying to connect to network
Currently there is no reasonable identification if the device is trying to connect or not.
This will add a blinking led when device is trying to connect to network.
chore: do strict unmarshaling of configuration
Unmarshaling of types that implement custom unmarshaling interface will not use that option,
which in case of this configuration will lead to basically loosing that setting.
KnownFields not supported in Node.Decode go-yaml/yaml#460
This change adds strict unmarshaling, though in not ideal way.
Also add test that tries to load example configurations as first test for their validity.