Option to delete none whitelisted domains in certificate update #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fffonion
reviewed
Mar 25, 2024
lib/resty/acme/autossl.lua
Outdated
| @@ -332,10 +333,23 @@ function AUTOSSL.check_renew(premature) | |||
| goto continue | |||
| end | |||
|
|
|||
| local domain = deserialized.domain | |||
| if not AUTOSSL.is_domain_whitelisted(domain, true) then | |||
| log(ngx_INFO, "domain ", domain, " not in whitelist, skipping") | |||
There was a problem hiding this comment.
Suggested change
| log(ngx_INFO, "domain ", domain, " not in whitelist, skipping") | |
| log(ngx_INFO, "domain ", domain, " not in whitelist but exists in storage, skipping renewal") |
There was a problem hiding this comment.
since you will actually delete the not whitelisted domain afterwards, it's not always "skipping". so this log line will need to move to after Line 345 and don't show if AUTOSSL.config.enabled_delete_not_whitelisted_domain is true.
|
Thank you @yuweizzz ! |
kikito
pushed a commit
to Kong/kong
that referenced
this pull request
Apr 23, 2024
### Summary #### [0.13.0] - 2024-03-28 ##### bug fixes - **autossl:** log the errors on the list certificates request ([#110](fffonion/lua-resty-acme#110)) [6c9760f](fffonion/lua-resty-acme@6c9760f) #### features - **autossl:** add option to delete none whitelisted domains in certificate renewal ([#112](fffonion/lua-resty-acme#112)) [1bbf39c](fffonion/lua-resty-acme@1bbf39c) Signed-off-by: Aapo Talvensaari <aapo.talvensaari@gmail.com>
bungle
added a commit
to Kong/kong
that referenced
this pull request
Apr 23, 2024
### Summary #### [0.13.0] - 2024-03-28 ##### bug fixes - **autossl:** log the errors on the list certificates request ([#110](fffonion/lua-resty-acme#110)) [6c9760f](fffonion/lua-resty-acme@6c9760f) #### features - **autossl:** add option to delete none whitelisted domains in certificate renewal ([#112](fffonion/lua-resty-acme#112)) [1bbf39c](fffonion/lua-resty-acme@1bbf39c) Signed-off-by: Aapo Talvensaari <aapo.talvensaari@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #85