Check if domain is whitelisted before cert renewal #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kfigiela I composed a reply but forgot to sent... I think overall it looks good, probably instead of |
|
Sounds like a good suggestion, I'll refactor this. I'd like to keep semantics of |
|
Yeah that sounds good.
--
Regards
fffonion (B607 2745 84E8 D5E5 <https://yooooo.us/gpg.txt>)
|
|
Don't know why i missed this PR for a long time... anyway it's merged, thanks you for the contribution @kfigiela ! |
bungle
added a commit
to Kong/kong
that referenced
this pull request
Aug 4, 2021
### Summary #### bug fixes - ***:** popup errors from lower functions [a19e9c8](fffonion/lua-resty-acme@a19e9c8) - **autossl:** pass storage config to acme client ([#43](fffonion/lua-resty-acme#43)) [ef1e541](fffonion/lua-resty-acme@ef1e541) #### features - **autossl:** add challenge_start_delay [df4ba0b](fffonion/lua-resty-acme@df4ba0b) - **autossl:** check if domain is whitelisted before cert renewal ([#35](fffonion/lua-resty-acme#35)) [942c007](fffonion/lua-resty-acme@942c007) - **client:** add challenge_start_callback [1c9b2d5](fffonion/lua-resty-acme@1c9b2d5) - **client:** allow to read "alternate" link and select preferred chain ([#42](fffonion/lua-resty-acme#42)) [ff17a74](fffonion/lua-resty-acme@ff17a74) - **storage/vault:** add support for kubernetes auth ([#37](fffonion/lua-resty-acme#37)) [93c2121](fffonion/lua-resty-acme@93c2121)
bungle
added a commit
to Kong/kong
that referenced
this pull request
Aug 5, 2021
### Summary #### bug fixes - ***:** popup errors from lower functions [a19e9c8](fffonion/lua-resty-acme@a19e9c8) - **autossl:** pass storage config to acme client ([#43](fffonion/lua-resty-acme#43)) [ef1e541](fffonion/lua-resty-acme@ef1e541) #### features - **autossl:** add challenge_start_delay [df4ba0b](fffonion/lua-resty-acme@df4ba0b) - **autossl:** check if domain is whitelisted before cert renewal ([#35](fffonion/lua-resty-acme#35)) [942c007](fffonion/lua-resty-acme@942c007) - **client:** add challenge_start_callback [1c9b2d5](fffonion/lua-resty-acme@1c9b2d5) - **client:** allow to read "alternate" link and select preferred chain ([#42](fffonion/lua-resty-acme#42)) [ff17a74](fffonion/lua-resty-acme@ff17a74) - **storage/vault:** add support for kubernetes auth ([#37](fffonion/lua-resty-acme#37)) [93c2121](fffonion/lua-resty-acme@93c2121)
bungle
added a commit
to Kong/kong
that referenced
this pull request
Aug 5, 2021
### Summary #### bug fixes - ***:** popup errors from lower functions [a19e9c8](fffonion/lua-resty-acme@a19e9c8) - **autossl:** pass storage config to acme client ([#43](fffonion/lua-resty-acme#43)) [ef1e541](fffonion/lua-resty-acme@ef1e541) #### features - **autossl:** add challenge_start_delay [df4ba0b](fffonion/lua-resty-acme@df4ba0b) - **autossl:** check if domain is whitelisted before cert renewal ([#35](fffonion/lua-resty-acme#35)) [942c007](fffonion/lua-resty-acme@942c007) - **client:** add challenge_start_callback [1c9b2d5](fffonion/lua-resty-acme@1c9b2d5) - **client:** allow to read "alternate" link and select preferred chain ([#42](fffonion/lua-resty-acme#42)) [ff17a74](fffonion/lua-resty-acme@ff17a74) - **storage/vault:** add support for kubernetes auth ([#37](fffonion/lua-resty-acme#37)) [93c2121](fffonion/lua-resty-acme@93c2121)
fffonion
pushed a commit
that referenced
this pull request
Apr 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like to prevent renewals on domains that are no longer whitelisted. To implement this I've extracted whitelist check to the separate function and use this in
update_cert.Also, since I'm gonna use dynamic whitelist with some caching in the worker process, I'd like to bypass cache for lookups during renewal. I've added
sourceargument todomain_whitelist_callbackfunction.@fffonion, do you have any thoughts on this?
This is somehow related to #15.