Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix basic video effect #272

Merged
merged 2 commits into from
Jun 28, 2022
Merged

Fix basic video effect #272

merged 2 commits into from
Jun 28, 2022

Conversation

lukasf
Copy link
Member

@lukasf lukasf commented Jun 26, 2022

The namespace change broke the video effect.

We could take this chance to also rename the video effect. Perhaps rename to HardwareVideoEffect?
I do not want to keep the old namespace for it, so we have a breaking change anyways.

@brabebhin
Copy link
Collaborator

Out of curiosity, what Windows version do you use?
The video effect works periodically for me now, still getting the "window destroyed" error, it sometimes randomly fails activation (similar to other bugs i've encountered with it).

I am still pretty sure this has nothing to do with our library and only MF bugs.

@lukasf
Copy link
Member Author

lukasf commented Jun 27, 2022

Huh really? For me it is super stable. I am on Windows 10 21H2. Do errors occur also in the sample app for you? I know that there are problems when using effects with MediaPlaybackList. But without that, I have never seen issues.

@brabebhin
Copy link
Collaborator

In hindsight, we should probably use a const for the activatable class ID when registering the effect.

The issue occurs with the samples on my laptop but does not occur on my PC. I installed some special nVidia drivers on my laptop (was using the GPU for some very nasty compute stuff) which is the only significant difference between you, my laptop and my PC. I would not pay too much attention to this.

We could also extract this into a different library. It would indeed make more sense than keeping it the main project.

@lukasf lukasf merged commit 1a77235 into master Jun 28, 2022
@lukasf lukasf deleted the fix-video-effect branch June 28, 2022 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants