Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check if there's a way to detect the broker / cluster version automatically #63

Closed
fgeller opened this issue Aug 1, 2017 · 0 comments
Closed

check if there's a way to detect the broker / cluster version automatically #63

fgeller opened this issue Aug 1, 2017 · 0 comments

Comments

@fgeller
Copy link
Owner

fgeller commented Aug 1, 2017 •
edited
Loading

... otherwise try to find a better way of identifying errs due to version mismatch. EOF's aren't that helpful.
fgeller added a commit that referenced this issue Aug 4, 2017
@fgeller
defaults to v0.10.0.0. #63
52d2f18 
defaulting to v0.10.1.0 breaks client.GetOffset against brokers that are older
than v0.10.1.0. i thought of fixing this by detecting the broker version
automatically #63. but that is a bit overkill at the moment imo, as support for
ApiVersionsRequest was only added in v0.10.0.0 - so the only distinction the
automatic resolver could make is between v0.10.0.0 and v0.10.1.0 - all other
versioning happened before v0.10.0.0. the additional features around time based
offset searching are not yet supported in kt, so there's no need to require
v0.10.1.0 at this point.
@fgeller fgeller closed this as completed Aug 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fgeller