Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on the asset pipeline #83

Merged
merged 1 commit into from
Feb 24, 2018
Merged

Conversation

sauy7
Copy link
Contributor

@sauy7 sauy7 commented Feb 23, 2018

Inline JS, CSS and images (latter as data uris) to avoid dependency on sprockets

The dependency is a problem for API-only Rails applications and Rails applications that do not use sprockets for managing static assets.

Copy link
Contributor

@pseudomuto pseudomuto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!

At some point, I think it would be really nice that have these views generated somehow. But another problem for another day...

Thanks for making this is thing! 👍

@@ -16,15 +16,5 @@ class Engine < ::Rails::Engine
)
end
end

initializer 'assets' do |_app|
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@pseudomuto pseudomuto merged commit d6c6455 into fgrehm:master Feb 24, 2018
@thejbsmith
Copy link

Guys, this is great work, and exactly what I need! Any chance of getting a new version of the gem pushed out with these changes incorporated?

@jairovm
Copy link

jairovm commented Jul 11, 2018

In the meantime, this worked for me

  gem 'letter_opener_web', github: 'fgrehm/letter_opener_web', ref: 'ab50ad0'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants