This repository has been archived by the owner on Nov 24, 2022. It is now read-only.
Support private networking using DHCP #352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -26,16 +26,19 @@ def configure_private_networks(env) | |||
| next if type.to_sym != :private_network | |||
|
|
|||
| container_name = env[:machine].provider.driver.container_name | |||
| address_type = config[:type] | |||
| ip = config[:ip] | |||
| bridge_ip = config.fetch(:lxc__bridge_ip) { build_bridge_ip(ip) } | |||
| bridge = config.fetch(:lxc__bridge_name) | |||
There was a problem hiding this comment.
Is there a reason for the double underscore ("lxc__bridge" vs "lxc_bridge") in these variable names? That tripped me up initially.
There was a problem hiding this comment.
IIRC this is kinda like the vagrant way of setting "type specific things". Like the rsync__args for the rsync synced folder or linux__nfs_options for NFS synced folders.
HTH
|
LGTM, I'll make sure this gets merged for the next release. Thanks for the contribution! |
fgrehm
added a commit
that referenced
this pull request
Apr 6, 2015
Support private networking using DHCP
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a type option similar to the way vagrant core does this: http://docs.vagrantup.com/v2/networking/private_network.html. This patch currently depends on a pre-existing dhcp server listening on the bridged network (this was the case after installing the lxc package on Ubuntu). The type option isn't strictly necessary as-is, but would be useful if you want to support starting a dhcp server as needed.