This repository has been archived by the owner on Nov 24, 2022. It is now read-only.
Create networking bridge if it is missing #380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry for the long silence but as per GH-375 I'm looking for help to maintain this plugin and for now I'm holding back from bringing in new changes =/ If you are interested on maintaining the project and keep things moving please shoot me an email or drop a message on GH-375 so I can arrange things. Cheers 🍻 |
|
Thanks for the feedback. Looking forward to a new release which contains this fix... |
|
Thanks for the PR. Looks good in general. Could you maybe rewrite the calls to |
|
Done, please check again. |
|
Thanks! 🍻 Conflict with current master fixed and merged. |
|
Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, a bridge device of an existing bridge must be specified for private networking support.
Create that bridge automatically if needed.