Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transfer _bookdown.yml - fix leanpub render on _Quizzes repo #40

Merged
merged 2 commits into from
Oct 6, 2022

Conversation

cansavvy
Copy link
Contributor

@cansavvy cansavvy commented Oct 6, 2022

Purpose/implementation Section

What changes are being implemented in this Pull Request?

Render leanpub on FH_Cluster_Guide_Quizzes is not happening because of an error that the _bookdown.yml file is not there:

https://github.com/fhdsl/FH_Cluster_Guide_Quizzes/actions/runs/3198705156/jobs/5223572231

So this is to make sure that file gets there so the render_leanpub happens and manuscript/ will be made and Leanpub can be published from that.

I'll be making this same change on OTTR_Template: jhudsl/OTTR_Template#574

@cansavvy cansavvy changed the title Transfer _bookdown.yml Transfer _bookdown.yml - fix leanpub render on _Quizzes repo Oct 6, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2022

No spelling errors! 🎉
Comment updated at 2022-10-06 with changes from 6d241b5

@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2022

No broken URLs detected! 🎉
Comment updated at 2022-10-06 with changes from 6d241b5

@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2022

Re-rendered previews from the latest commit:

Updated at 2022-10-06 with changes from 6d241b5

@cansavvy
Copy link
Contributor Author

cansavvy commented Oct 6, 2022

The quiz check is failing because quizzes/ doesn't exist. Is this expected, @avahoffman ? If so, I'm assuming this repo should have config_automation.yml have check_quizzes: no?

@avahoffman
Copy link
Contributor

Right, I deleted when testing things. I didn't change it in config though.

@cansavvy
Copy link
Contributor Author

cansavvy commented Oct 6, 2022

Right, I deleted when testing things. I didn't change it in config though.

Turned off check_quizzes

@cansavvy
Copy link
Contributor Author

cansavvy commented Oct 6, 2022

This should be ready to merge. I'm just testing a thing on OTTR_Quizzes real quick to make sure.

@cansavvy
Copy link
Contributor Author

cansavvy commented Oct 6, 2022

All set! This should do the trick, @avahoffman

@avahoffman avahoffman merged commit 0255922 into main Oct 6, 2022
@avahoffman avahoffman deleted the cansavvy/leanpub-fix-patch branch October 6, 2022 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants