Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible branch conflicts OTTR render fix #41

Merged
merged 1 commit into from
Jun 3, 2024
Merged

Conversation

cansavvy
Copy link
Contributor

Purpose/implementation Section

What changes are being implemented in this Pull Request?

I'm noticing in https://github.com/fhdsl/Intro_to_R/actions/runs/9227621475 render-tocless is finishing first (which is unusual) and may be the culprit for the branch conflicts.

If my hypothesis is right this change should resolve it. The way to test this is to: 1) merge this branch 2) Go to Actions > Render All Output Courses and click Run Workflow and run workflow again.

If this fixes the problem, I will also make this change on OTTR_Template, so let me know! (I've never seen this before -- very strange but would love to get to the bottom of it!)

Copy link
Contributor

github-actions bot commented May 24, 2024

⚠️ broken url errors ⚠️
There are broken url errors that need to be addressed.
Click here ➡️ for broken url errors!
Add errors that aren't errors to the resources/ignore-urls.txt file of this repo.
If you are having troubles see this guide
Comment updated at 2024-05-24-17:25:56 with changes from fa9ccce

@cansavvy cansavvy changed the title Possible branch conflicts for OTTR render fix Possible branch conflicts OTTR render fix May 24, 2024
@caalo caalo merged commit 6b5c59e into main Jun 3, 2024
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants