Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up the QA report #95

Closed
mrinnetmaki opened this issue Mar 30, 2023 · 4 comments
Closed

Clean up the QA report #95

mrinnetmaki opened this issue Mar 30, 2023 · 4 comments
Assignees
Milestone

Comments

@mrinnetmaki
Copy link
Collaborator

Let's work though all of the issues in the QA report (https://fhir.fi/finnish-base-profiles/qa.html) and fix as much as we can.

One way to clean it up is to just hide the errors. See #94. However, that should never be the first option.

We need to discuss what to do with the examples imported from Kanta PHR. They have quite a few errors. I'm guessing it could be nice to leave some information on these visible in this implementation guide, so implementers could have a way to evaluate how much they should trust any particular example. Any other views?

@mikajylha
Copy link
Collaborator

#91 contains fixes for condition examples

@mrinnetmaki
Copy link
Collaborator Author

Also #93 does a bit of cleaning up.

@mikajylha
Copy link
Collaborator

mikajylha commented Aug 17, 2023

#164 more cleanup

@mrinnetmaki
Copy link
Collaborator Author

All errors now have an explanation in the guide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants