-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Condition, Encounter and Provenance fixes #103
Conversation
Had a typo
Fixes errors in encounter examples. References were to non-existing resources.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments, but up to you @mikajylha if you want to react to them. OK for me to pull this in as is, too.
@@ -20,3 +20,17 @@ Usage: #example | |||
* telecom[0].system = #phone | |||
* telecom[0].value = "0401578947" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we wanted to be really fancy, we could use the URL (tel:+358401578947
) as value (see https://hl7.org/fhir/datatypes.html#ContactPoint):
If capturing a phone, fax or similar contact point, the value should be a properly formatted telephone number according to ITU-T E.123 icon. However, this is frequently not possible due to legacy data and/or clerical practices when recording contact details. For this reason, phone, fax, pager, and email addresses are not handled as formal URLs.
And then let it up to clients to format the phone numbers as they see fit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd kind of like to see that kind of encouragement in the implementation guide...
@@ -20,3 +20,17 @@ Usage: #example | |||
* telecom[0].system = #phone | |||
* telecom[0].value = "0401578947" | |||
* active = true | |||
|
|||
// Providing minimal info of the parent organization for the example above, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could of course add this info in the description of the example too?
|
||
// Providing minimal info of the parent organization for the example above, | ||
// no need to express full hierarchy here. | ||
Instance: OrganizationPrimaryCareParent |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It may be hard to find the source for this instance from this file. I'd like to see one file per example. But that may just be a personal preference...
Fixes parts of #95