Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Condition, Encounter and Provenance fixes #103

Merged
merged 8 commits into from
Apr 17, 2023

Conversation

mikajylha
Copy link
Collaborator

@mikajylha mikajylha commented Apr 15, 2023

Fixes parts of #95

@mikajylha mikajylha changed the title Condition and encounter fixes Condition, Encounter and Provenance fixes Apr 15, 2023
Mika Jylhä added 4 commits April 15, 2023 12:18
@mikajylha mikajylha requested a review from mrinnetmaki April 15, 2023 09:45
@mikajylha mikajylha marked this pull request as ready for review April 15, 2023 09:45
@mikajylha mikajylha requested a review from Marvasuo April 15, 2023 09:46
Copy link
Collaborator

@mrinnetmaki mrinnetmaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments, but up to you @mikajylha if you want to react to them. OK for me to pull this in as is, too.

@@ -20,3 +20,17 @@ Usage: #example
* telecom[0].system = #phone
* telecom[0].value = "0401578947"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we wanted to be really fancy, we could use the URL (tel:+358401578947) as value (see https://hl7.org/fhir/datatypes.html#ContactPoint):

If capturing a phone, fax or similar contact point, the value should be a properly formatted telephone number according to ITU-T E.123 icon. However, this is frequently not possible due to legacy data and/or clerical practices when recording contact details. For this reason, phone, fax, pager, and email addresses are not handled as formal URLs.

And then let it up to clients to format the phone numbers as they see fit.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd kind of like to see that kind of encouragement in the implementation guide...

@@ -20,3 +20,17 @@ Usage: #example
* telecom[0].system = #phone
* telecom[0].value = "0401578947"
* active = true

// Providing minimal info of the parent organization for the example above,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could of course add this info in the description of the example too?


// Providing minimal info of the parent organization for the example above,
// no need to express full hierarchy here.
Instance: OrganizationPrimaryCareParent
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It may be hard to find the source for this instance from this file. I'd like to see one file per example. But that may just be a personal preference...

@mrinnetmaki mrinnetmaki added this to the STU 1 Release milestone Apr 16, 2023
@mikajylha mikajylha merged commit f43cf1c into master Apr 17, 2023
@mikajylha mikajylha deleted the condition_and_encounter_fixes branch April 17, 2023 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants