Adding Secret model and test #110
Conversation
| url_template = "/api/v1/namespaces/{namespace}/secrets/{name}" | ||
|
|
||
| metadata = Field(ObjectMeta) | ||
| data = Field(dict) |
There was a problem hiding this comment.
I wonder if it would be useful to also support the stringData field?
Preferably with a new field type to indicate that this is a write-only field. On the other hand, I don't think we have that anywhere else, so maybe it's not needed. Also, I'm not sure when the stringData field was introduced. Might cause problems if expecting to use it in a cluster that doesn't support it?
https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.19/#secret-v1-core
There was a problem hiding this comment.
Good question! The only use for this field is to provide not base64 encoded data, which will end up being merged into data field, so it's kind of redundant. Unless someone has a specific use case for this, I'd say it's not needed.
There was a problem hiding this comment.
Seems that we do not have any cluster with a k8s version without the stringData field so they will be no problem for add it.
There was a problem hiding this comment.
Let me see if I can minimize the Codacy complains and I'll add it. Thanks for the feedback!
There was a problem hiding this comment.
@mortenlj Added field stringData. Please give it a look, I've created a new WriteOnlyField type, I think is what you expected.
Also, is there a way to get rid of those picky errors about the methods defined not as functions? I think is the proper way to do it and follows the same structure as the rest of the models.
There was a problem hiding this comment.
Added field stringData. Please give it a look, I've created a new WriteOnlyField type, I think is what you expected.
👍
Also, is there a way to get rid of those picky errors about the methods defined not as functions? I think is the proper way to do it and follows the same structure as the rest of the models.
Technically, they could be moved to the top-level, outside the containing class, since it's not actually using anything from the class. Personally, I prefer to group tests in a class, but it's probably not necessary when there's only one class in the test file.
I guess you could decorate them with @staticmethod and see if that 1) works, 2) silences the linter. Or just move them to the top-level. Or just ignore them. 🤷
Preparing the library to support changes required by fiaas/fiaas-deploy-daemon#178