Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: EC2 2023 8.3-Torsion #122

Open
wants to merge 31 commits into
base: dev-ec2-2023
Choose a base branch
from
Open

feat: EC2 2023 8.3-Torsion #122

wants to merge 31 commits into from

Conversation

DanielGMorenaFhecor
Copy link
Collaborator

Here is my implementation of the Chapter 8.3-Torsion from the new Eurocode 2:2023.

mortenengen and others added 29 commits December 13, 2022 21:01
@mortenengen @talledodiego
Draft initial structure for the concrete class
2e70179 
Co-authored-by: talledodiego <38036285+talledodiego@users.noreply.github.com>
@mortenengen
Update docstring of base material
b8f67bb
@DanielGMorenaFhecor
minimum reinforcement areas functions
c299dcc
@DanielGMorenaFhecor
raise ValueError test functions for min area
59a04f5
@DanielGMorenaFhecor
crack_min_steel_without_direct_calculation
b7167aa
@DanielGMorenaFhecor
Commit
7189d31
@DanielGMorenaFhecor
crack without direct calculation tests
4a0fcfb
@DanielGMorenaFhecor
adjusted bond strength
84c0140
@DanielGMorenaFhecor
hc_eff_concrete_tension formulation and testing
e0f1baa
@DanielGMorenaFhecor
requiremets.txt updated
f2cbb49
@DanielGMorenaFhecor
rho_p_eff
333dcbe
@DanielGMorenaFhecor
kt load duration
59f1198
@DanielGMorenaFhecor
strain diff formula
34d85d2
@DanielGMorenaFhecor
chapter completed
a8ab129
@DanielGMorenaFhecor
imports and renamed functions
ce4e432
@DanielGMorenaFhecor
removed duplicate file
938c0f5
@DanielGMorenaFhecor
removed testing file
6ba6dc9
@DanielGMorenaFhecor
test renaming and docstring corrections
a9c9263
@DanielGMorenaFhecor
pull from upstream
50c65b7
@DanielGMorenaFhecor
Merge branch 'dev' of https://github.com/fib-international/structural…
ea3552b 
…codes into ec_2004_crack_control
@DanielGMorenaFhecor
230309 requested changes applied
4fd8b7e
@DanielGMorenaFhecor
small lint fixes
1cffa61
@DanielGMorenaFhecor
vscode config updated
b483d40
@DanielGMorenaFhecor
Merge branch 'dev' of https://github.com/fib-international/structural…
e9d953d 
…codes into dev
@DanielGMorenaFhecor
Merge branch 'dev' of https://github.com/fib-international/structural…
182e538 
…codes into dev
@DanielGMorenaFhecor
Merge branch 'dev' of https://github.com/fib-international/structural…
e509fb9 
…codes into dev
@DanielGMorenaFhecor
Merge branch 'dev' of https://github.com/fib-international/structural…
d57f945 
…codes into dev
@DanielGMorenaFhecor
Merge branch 'dev' of https://github.com/DanielGMorenaFhecor/structur…
bc049e4 
…alcodes into dev
@DanielGMorenaFhecor
torsion completed
04181e5
@DanielGMorenaFhecor DanielGMorenaFhecor added the enhancement New feature or request label Aug 2, 2024
@DanielGMorenaFhecor DanielGMorenaFhecor added the EC2 2023 Eurocode 2 (2023) label Aug 2, 2024
@DanielGMorenaFhecor DanielGMorenaFhecor self-assigned this Aug 2, 2024
@DanielGMorenaFhecor DanielGMorenaFhecor linked an issue Aug 5, 2024 that may be closed by this pull request
EC2 2023: Torsion and combined actions #55
Open
1 task
@mortenengen mortenengen removed this from the EC2 2023: Ultimate limit state milestone Aug 5, 2024
@mortenengen mortenengen changed the base branch from dev to dev-ec2-2023 October 10, 2024 19:30
@mortenengen mortenengen changed the base branch from dev-ec2-2023 to dev October 17, 2024 19:24
@mortenengen mortenengen changed the base branch from dev to dev-ec2-2023 October 17, 2024 19:24
mortenengen
mortenengen requested changes Oct 17, 2024
View reviewed changes
Copy link
Member

@mortenengen mortenengen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the good contribution 👍

I have merged dev and provided some minor fixes to the docstrings.

There are however a couple of lines that are not covered by tests. Please add tests so that we reach 100 % coverage for the added lines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mortenengen mortenengen mortenengen requested changes

@talledodiego talledodiego Awaiting requested review from talledodiego

Assignees

@DanielGMorenaFhecor DanielGMorenaFhecor

Labels
EC2 2023 Eurocode 2 (2023) enhancement New feature or request
Projects
EC2 2023 PR tracker
Status: Compliance review
PR tracker
Status: Under review 👀
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

EC2 2023: Torsion and combined actions
2 participants
@DanielGMorenaFhecor @mortenengen