Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate distribution and signing in Wallet interface #230

Open
2 tasks
olemis opened this issue Nov 10, 2019 · 0 comments
Open
2 tasks

Separate distribution and signing in Wallet interface #230

olemis opened this issue Nov 10, 2019 · 0 comments
Assignees
@olemis
Labels
core Core interfaces stdev wallet Wallet subsystem wip Work in progress
Milestone
next

Comments

@olemis
Copy link
Contributor

olemis commented Nov 10, 2019 •
edited
Loading

Feature description

Refactor core.Wallet interface for v2.

Is your feature request related to a problem? Please describe.
Address distribution , transaction creation and signing are altogether in core.Wallet interface. Besides the last two are quite similar to muiti-wallet API .

Describe the solution you'd like
Separate them three wallet aspects so that specialized concrete types may be built.

Describe alternatives you've considered
Keeping wallet contract in v1 API creates friction and duplication when trying to move forward.

Possible implementation

  • Just refactor , no new functionality need be added .
  • Update Skycoin plugin to wallet v2 API
@olemis olemis self-assigned this Nov 10, 2019
@olemis olemis added the wallet Wallet subsystem label Nov 10, 2019
@olemis olemis added this to the next milestone Nov 10, 2019
@olemis olemis mentioned this issue Nov 11, 2019
Open
4 tasks
@olemis olemis added core Core interfaces stdev wip Work in progress labels Dec 5, 2019
olemis added a commit to simelo/fibercryptowallet that referenced this issue Dec 6, 2019
@olemis
[ci] refs fibercrypto#230 - Remove unnecessary shell command in make …
a5a7061 
…gen-mocks
olemis added a commit to simelo/fibercryptowallet that referenced this issue Dec 6, 2019
@olemis
[sky] [core] [main] [models] [util] refs fibercrypto#230 - Rename cor…
90038e0 
…e.Wallet => core.FullWallet
olemis added a commit to simelo/fibercryptowallet that referenced this issue Dec 6, 2019
@olemis
[mockes] refs fibercrypto#230 - Regenerate mocks after renaming walle…
1b78680 
…t interface types
olemis added a commit to simelo/fibercryptowallet that referenced this issue Dec 9, 2019
@olemis
[ci] refs fibercrypto#230 - Init v2 changelog
d5d48d8
olemis added a commit to simelo/fibercryptowallet that referenced this issue Dec 9, 2019
@olemis
[core] refs fibercrypto#230 - Factor common FullWallet methods into a…
e028b54 
… separate Wallet contract
@olemis olemis mentioned this issue Dec 9, 2019
Open
11 tasks
olemis added a commit to simelo/fibercryptowallet that referenced this issue Feb 11, 2020
@olemis
[core] refs fibercrypto#230 - Factor out methods of FullWallet interf…
f27b9f9 
…ace into smaller interfaces
olemis added a commit to simelo/fibercryptowallet that referenced this issue Feb 11, 2020
@olemis
[core] refs fibercrypto#230 - Add BlockchainExplorer
5687804
olemis added a commit to simelo/fibercryptowallet that referenced this issue Feb 12, 2020
@olemis
[core] [main] [models] [util] refs fibercrypto#230 - Changes in core …
4929c49 
…interfaces for transaction signing

- SignServicesForTxn receives Wallet instead of FullWallet
- LoadTransactionAPI returns BlockchainVisor
- ReadyForTxn receives Wallet instance as first argument
olemis added a commit to simelo/fibercryptowallet that referenced this issue Feb 12, 2020
@olemis
[mocks] refs fibercrypto#230 - Update mocks after adding interfaces
59830e9 
... BlockchainExplorer, BlockchainVisor, Wallet, WatchWallet
olemis added a commit to simelo/fibercryptowallet that referenced this issue Feb 12, 2020
@olemis
[util] refs fibercrypto#230 - Fix infinite recursion on SimpleWalletA…
5e99ec9 
…ddress methods
olemis added a commit to simelo/fibercryptowallet that referenced this issue Feb 12, 2020
@olemis
[util] refs fibercrypto#230 - Update tests according to changes in Si…
846946e 
…mpleWalletOutput and SimpleWalletAddress
olemis added a commit to simelo/fibercryptowallet that referenced this issue Feb 12, 2020
@olemis
[sky] refs fibercrypto#230 - SkycoinBlockchain implements BlockchainV…
3abdbfc 
…isor

- Transfer not supported
- ScanOutputs not implemented
olemis added a commit to simelo/fibercryptowallet that referenced this issue Feb 12, 2020
@olemis
[sky] refs fibercrypto#230 - Fix signature of SkyFiberPlugin.LoadTran…
1a2d1f2 
…sactionAPI

... core.BlockchainTransactionAPI => core.BlockchainVisor
This was referenced Feb 13, 2020
Open
Open
Open
olemis added a commit to simelo/fibercryptowallet that referenced this issue Feb 13, 2020
@olemis
[sky] refs fibercrypto#230 - Remove Sign method of Skycoin wallets. I…
62f29e4 
…mplement DeriveParentPubKey
olemis added a commit to simelo/fibercryptowallet that referenced this issue Feb 13, 2020
@olemis
[sky] refs fibercrypto#230 - Skycoin wallets implement FullWallet int…
9339dfd 
…erface

- ReadyForTxn receives Wallet instead of FullWallet
- GetLoadedAddressesForAccount added but not implemented
- GetAllLoadedAddresses added but not implemented, and returns error
- GenAddresses returns error
- Add ErrInvalidArgument, and ErrInvalidAccount error conditions
olemis added a commit to simelo/fibercryptowallet that referenced this issue Feb 13, 2020
@olemis
[sky] refs fibercrypto#230 - Fix typos errors.ErrNotImplemented in wa…
5522eab 
…llet code
olemis added a commit to simelo/fibercryptowallet that referenced this issue Feb 13, 2020
@olemis
[sky] refs fibercrypto#230 - Convert to WatchWallet prior to requesti…
9365aa5 
…ng addresses in checkEquivalentSkycoinWallets
olemis added a commit to simelo/fibercryptowallet that referenced this issue Feb 13, 2020
@olemis
[sky] refs fibercrypto#230 - Fix wallet test code to cope with wallet…
60ee867 
… v2 API changes
olemis added a commit to simelo/fibercryptowallet that referenced this issue Feb 13, 2020
@olemis
[core] refs fibercrypto#230 - Wallet iterator type not bound to FullW…
985dfc4 
…allet
olemis added a commit to simelo/fibercryptowallet that referenced this issue Feb 13, 2020
@olemis
[sky] refs fibercrypto#230 - SkycoinWalletIterator relies upon Wallet
e1d61d2
olemis added a commit to simelo/fibercryptowallet that referenced this issue Feb 13, 2020
@olemis
[sky] refs fibercrypto#230 - Fix account test cases considering walle…
73e39f4 
…t v2 API changes
olemis added a commit to simelo/fibercryptowallet that referenced this issue Feb 13, 2020
@olemis
[sky] refs fibercrypto#230 - Change makeSimpleWalletAddress and makeS…
61bae0c 
…impleWalletOutput

... since there is neither WalletAddress nor WalletOutput no more
olemis added a commit to simelo/fibercryptowallet that referenced this issue Feb 13, 2020
@olemis
[sky] refs fibercrypto#230 - Return different addresses in TestRemote…
a9faed5 
…WalletGenAddresses
olemis added a commit to simelo/fibercryptowallet that referenced this issue Feb 13, 2020
@olemis
[sky] refs fibercrypto#230 - Let mock generate different address in T…
43ace46 
…estRemoteWalletGenAddresses
olemis added a commit to simelo/fibercryptowallet that referenced this issue Feb 13, 2020
@olemis
[models] refs fibercrypto#230 - Start uypgrading QML models code to u…
195041b 
…se wallet v2 API
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@olemis olemis

Labels
core Core interfaces stdev wallet Wallet subsystem wip Work in progress
Projects
None yet
Milestone
next
Development

No branches or pull requests
1 participant
@olemis