Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in test sort transactions. #83

Closed
isaacvr opened this issue Oct 31, 2019 · 0 comments
Closed

Bug in test sort transactions. #83

isaacvr opened this issue Oct 31, 2019 · 0 comments
Labels
bug Something isn't working

Comments

@isaacvr
Copy link

isaacvr commented Oct 31, 2019

Describe the bug
Bug in tests after fixing isSHA256Eq

Environment information:

  • Platform: Linux 4.19.0-1-amd64 x86_64
  • Go environment:
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/adacosta/.cache/go-build"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/usr/share/gocode"
GOPROXY=""
GORACE=""
GOROOT="/opt/go"
GOTMPDIR=""
GOTOOLDIR="/opt/go/pkg/tool/linux_amd64"
GCCGO="gccgo"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build114971256=/tmp/go-build -gno-record-gcc-switches"
  • Compiler info:
gcc (Debian 8.3.0-6) 8.3.0
Copyright (C) 2018 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Steps to Reproduce
Steps to reproduce the behavior:

  1. Fix this error.
  2. make test-libc
  3. See error

Actual behavior
Tests fail

lib/cgo/tests/check_coin.transactions.c:983:F:coin.transaction:TestSortTransactions:0: Failed SortTransactions test "invalid fee multiplication is capped"

Expected behavior
Tests should pass

Additional context
skycoin/libskycoin#34

Possible implementation:

PD: The "Possible implementation:" just try to make you follow some possible relevant paths than can be relevant in order to find the bug.

@isaacvr isaacvr added the bug Something isn't working label Oct 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants