Skip to content

Bump webpki from 0.22.0 to 0.22.1 (#52) #249

Bump webpki from 0.22.0 to 0.22.1 (#52)

Bump webpki from 0.22.0 to 0.22.1 (#52) #249

GitHub Actions / clippy succeeded Oct 10, 2023 in 0s

clippy

1 warning

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 1
Note 0
Help 0

Versions

  • rustc 1.73.0 (cc66ad468 2023-10-03)
  • cargo 1.73.0 (9c4383fb5 2023-08-26)
  • clippy 0.1.73 (cc66ad4 2023-10-03)

Annotations

Check warning on line 136 in providers/cloudwatch/src/client/canonical_request.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

use of `format!` to build up a string from an iterator

warning: use of `format!` to build up a string from an iterator
   --> providers/cloudwatch/src/client/canonical_request.rs:132:31
    |
132 |           let headers: String = self
    |  _______________________________^
133 | |             .headers
134 | |             .iter()
135 | |             .map(|(k, v)| format!("{k}:{v}\n"))
136 | |             .collect::<String>()
    | |________________________________^
    |
help: call `fold` instead
   --> providers/cloudwatch/src/client/canonical_request.rs:135:14
    |
135 |             .map(|(k, v)| format!("{k}:{v}\n"))
    |              ^^^
help: ... and use the `write!` macro here
   --> providers/cloudwatch/src/client/canonical_request.rs:135:27
    |
135 |             .map(|(k, v)| format!("{k}:{v}\n"))
    |                           ^^^^^^^^^^^^^^^^^^^^
    = note: this can be written more efficiently by appending to a `String` directly
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#format_collect
    = note: `#[warn(clippy::format_collect)]` on by default