[WIP] CSDK support on Windows #217
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Temburwar <shrikant.temburwar@intel.com>
Signed-off-by: Temburwar <shrikant.temburwar@intel.com>
tajnisha
reviewed
Feb 20, 2023
WinClientBuild/3rdParty_build.bat
Outdated
| nmake /f Makefile.vc mode=static ENABLE_WINSSL=yes | ||
| cd ..\..\.. | ||
| cd 3rdParty\safestringlib-1.2.0\WinBuild | ||
| msbuild WinBuild.sln /p:configuration=debug /t:Rebuild /p:platform=x86 |
There was a problem hiding this comment.
Can we update this script to get release or debug configuration from user ?
tajnisha
reviewed
Feb 20, 2023
WinClientBuild/README.md
Outdated
| # Windows* OS | ||
| The development and execution OS used was `Windows 10` on x86. Follow these steps to compile and execute FIDO Device Onboard (FDO). | ||
|
|
||
| The FDO Client SDK execution depends on OpenSSL* toolkit 1.1.1s version. Users must install or upgrade the toolkit before compilation if the toolkit is not available by default in the environment. |
There was a problem hiding this comment.
we may have to upgrade to openssl 3 in some time.
tajnisha
reviewed
Feb 20, 2023
WinClientBuild/README.md
Outdated
| > ***NOTE***: Built binary can be either `debug` or `release` based on the compilation step. | ||
|
|
||
| - Before executing `win-client.exe`, prepare for Device Initialization (DI) by starting the FDO PRI Manufacturer. | ||
| Refer to [ Device Initialization Setup ](DI_setup.md). |
There was a problem hiding this comment.
Check whether this hyper link works, I observed file not found.
tajnisha
reviewed
Feb 20, 2023
WinClientBuild/README.md
Outdated
| ``` | ||
|
|
||
| - To enable the device for Transfer Ownership protocol (TO1 and TO2), configure the FDO PRI Rendezvous and Owner. | ||
| Refer to [ Ownership Transfer Setup ](ownership_transfer.md). |
There was a problem hiding this comment.
Check whether this hyper link works, I observed file not found.
tajnisha
reviewed
Feb 20, 2023
WinClientBuild/csdk_build.bat
Outdated
| REM call "C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Auxiliary\Build\vcvarsall.bat" x86 | ||
| del build\win-client.exe | ||
| SET CL=/DECDSA_PRIVKEY#\"C:\\ProgramData\\Intel\\FDO\\data\\ecdsa384privkey.pem\" | ||
| msbuild WinClientBuild.sln /p:MyConstants="ECDSA384_DA;AES_MODE_GCM_ENABLED;REUSE_SUPPORTED;RESALE_SUPPORTED" /p:configuration=debug /t:Rebuild /p:platform=x86 |
There was a problem hiding this comment.
Get the debug/release configuration from user.
tajnisha
reviewed
Feb 20, 2023
app/se_provisioning.c
Outdated
| @@ -4,9 +4,13 @@ | |||
| */ | |||
|
|
|||
| #include <stdio.h> | |||
| #ifndef WIN32 | |||
There was a problem hiding this comment.
if we remove the ifndef here, was it able to use safe string libs ?
Signed-off-by: Temburwar <shrikant.temburwar@intel.com>
shrikant1407
changed the title
tajnisha
reviewed
Feb 22, 2023
|
|
||
| /* Allow only alphanumeric file name either shell or python script*/ | ||
| static bool is_valid_filename(const char *fname) | ||
| { | ||
| bool ret = false; | ||
| int strcmp_result = -1; | ||
| uint8_t i = 0; | ||
| static const char * const whitelisted[] = {"sh", "py"}; | ||
| static const char *const whitelisted[] = {"sh", "py", "bat"}; |
There was a problem hiding this comment.
Should this be a different list for linux{py, sh} and windows{py, bat} ?
Signed-off-by: Temburwar <shrikant.temburwar@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Shrikant Temburwar shrikant.temburwar@intel.com